Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We still have logs in the filesystem. #46

Closed
imain opened this issue May 15, 2019 · 4 comments · Fixed by #97
Closed

We still have logs in the filesystem. #46

imain opened this issue May 15, 2019 · 4 comments · Fixed by #97
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@imain
Copy link
Contributor

imain commented May 15, 2019

We shouldn't be logging to the filesystem. We still have logs going into the shared volume. Eventually this will just balloon and cause problems. All logs should go to stdout, or else we need to implement a log rotation scheme.
@dtantsur
Copy link
Member

dtantsur commented Jul 8, 2019

This is correct, and we're close to fixing it. However, the ramdisk logs are just tarballs, we cannot put them to stdout.

@imain
Copy link
Contributor Author

imain commented Jul 16, 2019 •
edited
Loading

OK that's fine. It is part of the interface in kubernetes that the containers log to stdout. That way you can get logs via the command line. We should try to get as many as we can working this way.

derekhiggins added a commit to derekhiggins/ironic-image that referenced this issue Sep 19, 2019
@derekhiggins
Stop logging to file
f043d41 
Rely instead on the logs to std out/err for each container

Fixes: metal3-io#46
@derekhiggins derekhiggins mentioned this issue Sep 19, 2019
Merged
derekhiggins added a commit to derekhiggins/ironic-image that referenced this issue Nov 22, 2019
@derekhiggins
Stop logging to file
f6a34e4 
Rely instead on the logs to std out/err for each container

Fixes: metal3-io#46
derekhiggins added a commit to derekhiggins/ironic-image that referenced this issue Nov 25, 2019
@derekhiggins
Stop logging to file
8b4ceb6 
Rely instead on the logs to std out/err for each container

Fixes: metal3-io#46
@longkb longkb mentioned this issue Dec 19, 2019
Merged
elfosardo pushed a commit to elfosardo/ironic-image that referenced this issue Mar 5, 2020
@derekhiggins @elfosardo
Stop logging to file
c763b2e 
Rely instead on the logs to std out/err for each container

Fixes: metal3-io#46
(cherry picked from commit 8b4ceb6)
elfosardo pushed a commit to elfosardo/ironic-image that referenced this issue Mar 5, 2020
@derekhiggins @elfosardo
Stop logging to file
a84aa43 
Rely instead on the logs to std out/err for each container

Fixes: metal3-io#46
(cherry picked from commit 8b4ceb6)
elfosardo pushed a commit to elfosardo/ironic-image that referenced this issue Mar 5, 2020
@derekhiggins @elfosardo
Stop logging to file
19f86e4 
Rely instead on the logs to std out/err for each container

Fixes: metal3-io#46
(cherry picked from commit 8b4ceb6)
derekhiggins pushed a commit to derekhiggins/ironic-image that referenced this issue Oct 13, 2020
@longkb @derekhiggins
Remove outdated instruction related to log files
0801a1d 
Currently, log files is disabled by metal3-io#46. This PR aims to remove this outdated infomation from README.md

Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>
derekhiggins pushed a commit to derekhiggins/ironic-image that referenced this issue Oct 14, 2020
@longkb @derekhiggins
Remove outdated instruction related to log files
5540c39 
Currently, log files is disabled by metal3-io#46. This PR aims to remove this outdated infomation from README.md

Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>
@dtantsur
Copy link
Member

We still have log files because of rdo-packages/ironic-distgit@64c9b50, will fix.

@dtantsur dtantsur reopened this Nov 29, 2022
@metal3-io-bot metal3-io-bot added the needs-triage Indicates an issue lacks a `triage/foo` label and requires one. label Nov 29, 2022
@dtantsur
Copy link
Member

/triage accepted
/kind bug

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. kind/bug Categorizes issue or PR as related to a bug. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Nov 29, 2022
metal3-io-bot added a commit that referenced this issue Nov 30, 2022
@metal3-io-bot
Merge pull request #401 from dtantsur/no-dist-conf
2c765fa 
Remove RDO distribution configuration (finally fixes #46)
dtantsur added a commit to dtantsur/ironic-image that referenced this issue Dec 5, 2022
@dtantsur
Remove RDO distribution configuration (finally fixes metal3-io#46)
044b0d6 
It forces using /var/log/ironic/ironic.log, which is not necessary in
containers and also grows indefinitely since log rotation is not enabled.

(cherry picked from commit 8621a3b)
dtantsur pushed a commit to dtantsur/ironic-image that referenced this issue Dec 5, 2022
@openshift-merge-robot
Merge pull request metal3-io#327 from openshift-cherrypick-robot/cher…
379eae5 
…ry-pick-326-to-release-4.12

OCPBUGS-4311: Remove RDO distribution configuration (finally fixes metal3-io#46)
elfosardo pushed a commit to elfosardo/ironic-image that referenced this issue Dec 12, 2022
@dtantsur @rhjanders
Remove RDO distribution configuration (finally fixes metal3-io#46)
e92d3bf 
It forces using /var/log/ironic/ironic.log, which is not necessary in
containers and also grows indefinitely since log rotation is not enabled.

(cherry picked from commit 8621a3b)
elfosardo pushed a commit to elfosardo/ironic-image that referenced this issue Dec 12, 2022
@openshift-merge-robot
Merge pull request metal3-io#326 from rhjanders/no-dist-conf-ocp-master
acd0274 
Bug OCPBUGS-4305: Remove RDO distribution configuration (finally fixes metal3-io#46)
elfosardo pushed a commit to elfosardo/ironic-image that referenced this issue Dec 15, 2022
@dtantsur
Remove RDO distribution configuration (finally fixes metal3-io#46)
8ebdc55 
It forces using /var/log/ironic/ironic.log, which is not necessary in
containers and also grows indefinitely since log rotation is not enabled.

(cherry picked from commit 8621a3b)
elfosardo pushed a commit to elfosardo/ironic-image that referenced this issue Dec 15, 2022
@openshift-merge-robot
Merge pull request metal3-io#328 from openshift-cherrypick-robot/cher…
f9a594d 
…ry-pick-327-to-release-4.11

OCPBUGS-4410: Remove RDO distribution configuration (finally fixes metal3-io#46)
elfosardo pushed a commit to elfosardo/ironic-image that referenced this issue Feb 15, 2023
@dtantsur
Remove RDO distribution configuration (finally fixes metal3-io#46)
a2a6acf 
It forces using /var/log/ironic/ironic.log, which is not necessary in
containers and also grows indefinitely since log rotation is not enabled.

(cherry picked from commit 8621a3b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop logging to file derekhiggins/ironic-image
3 participants
@imain @dtantsur @metal3-io-bot