-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-adding Train features #101
Conversation
1f1d626
to
eb73cca
Compare
eb73cca
to
3897029
Compare
b856930
to
548c6e8
Compare
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1221/ |
548c6e8
to
a152803
Compare
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1231/ |
This patch adds back the features that were removed because we were on Stain branch: - continuous introspection - ironic-prometheus-exporter - mdns support
a152803
to
a98a0cc
Compare
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1236/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Has anyone tried it?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, dtantsur, elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CI has, the failure is unrelated and after the ironic parts, |
This patch adds back the features that were removed because we
were on Stain branch:
Also fixes #102
Please merge this and metal3-io/ironic-inspector-image#38 at the same time!