Support iLO4 and iLO5 BMCs #244

macaptain · 2021-03-12T07:38:52Z

This change adds configuration for the iLO driver as per https://docs.openstack.org/ironic/latest/admin/drivers/ilo.html. Also see #243.

The hardware interfaces for ilo are added to ironic.conf.j2. The python3-proliantutils dependency has also been added.

I'm currently testing this image with iLO 4.

fmuyassarov · 2021-03-12T08:16:46Z

/cc @dtantsur
/cc @dhellmann

macaptain · 2021-03-12T10:54:44Z

Getting an error in the conductor with this branch:

2021-03-12 10:36:22.461 1 ERROR ironic_lib.exception Traceback (most recent call last):
2021-03-12 10:36:22.461 1 ERROR ironic_lib.exception   File "/usr/lib/python3.6/site-packages/ironic/common/driver_factory.py", line 142, in default_interface
2021-03-12 10:36:22.461 1 ERROR ironic_lib.exception     get_interface(hw_type, interface_type, impl_name)
2021-03-12 10:36:22.461 1 ERROR ironic_lib.exception   File "/usr/lib/python3.6/site-packages/ironic/common/driver_factory.py", line 111, in get_interface
2021-03-12 10:36:22.461 1 ERROR ironic_lib.exception     hardware_type=hw_type.__class__.__name__)
2021-03-12 10:36:22.461 1 ERROR ironic_lib.exception ironic.common.exception.IncompatibleInterface: boot interface implementation '<ironic.drivers.modules.ipxe.iPXEBoot object at 0x7fabf58c9208>' is not supported by hardware type IloHardware.
2021-03-12 10:36:22.461 1 ERROR ironic_lib.exception 
2021-03-12 10:36:22.461 1 ERROR ironic_lib.exception During handling of the above exception, another exception occurred:
2021-03-12 10:36:22.461 1 ERROR ironic_lib.exception 
2021-03-12 10:36:22.461 1 ERROR ironic_lib.exception Traceback (most recent call last):
2021-03-12 10:36:22.461 1 ERROR ironic_lib.exception   File "/usr/lib/python3.6/site-packages/ironic_lib/exception.py", line 134, in __init__
2021-03-12 10:36:22.461 1 ERROR ironic_lib.exception     message = self._msg_fmt % kwargs
2021-03-12 10:36:22.461 1 ERROR ironic_lib.exception KeyError: 'node_info'
2021-03-12 10:36:22.461 1 ERROR ironic_lib.exception 
2021-03-12 10:36:22.466 1 ERROR ironic.conductor.base_manager [req-38fb2994-1585-42a5-89e4-dedfebddcf04 - - - - -] Failed to register hardware types. For%(node_info)s hardware type '%(driver)s', no default value found for %(interface_type)s interface.: ironic.common.exception.NoValidDefaultForInterface: For%(node_info)s hardware type '%(driver)s', no default value found for %(interface_type)s interface.

I believe this is happening when the conductor_hardware_interfaces in MariaDB is being populated by ironic-conductor.

dtantsur · 2021-03-12T14:49:53Z

I've proposed a fix for the KeyError: https://review.opendev.org/c/openstack/ironic/+/780270. Meanwhile, ilo requires a special boot interface: ilo-ipxe.

config/ironic.conf.j2

macaptain · 2021-03-15T07:51:41Z

/test-integration

fmuyassarov · 2021-03-15T09:26:20Z

/test-integration

config/ironic.conf.j2

dtantsur · 2021-03-15T13:44:20Z

config/ironic.conf.j2

-enabled_bios_interfaces = idrac-wsman,no-bios,redfish,idrac-redfish,irmc
-enabled_boot_interfaces = pxe,ipxe,fake,redfish-virtual-media,idrac-redfish-virtual-media
+enabled_bios_interfaces = idrac-wsman,no-bios,redfish,idrac-redfish,irmc,ilo
+enabled_boot_interfaces = ipxe,ilo-ipxe,pxe,ilo-pxe,fake,redfish-virtual-media,idrac-redfish-virtual-media,ilo-virtual-media,ilo-uefi-https


Let's not add ilo-uefi-https, we have no code to support it in BMO.

I've removed ilo-uefi-https.

This change adds configuration for the iLO driver as per https://docs.openstack.org/ironic/latest/admin/drivers/ilo.html The hardware interfaces for ilo are added to ironic.conf.j2 and the python3-proliantutils dependency has also been added.

metal3-io-bot · 2021-03-15T13:57:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, macaptain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dtantsur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dtantsur · 2021-03-15T13:57:31Z

Ouch, sorry, this needs rebasing because of another change (a mere file rename).

dtantsur · 2021-03-15T14:05:53Z

/test-integration

maelk · 2021-03-15T14:30:21Z

config/ironic.conf.j2

-enabled_power_interfaces = ipmitool,idrac,irmc,fake,redfish,idrac-redfish,ibmc
-enabled_raid_interfaces = no-raid,irmc,agent,fake,ibmc,idrac-wsman
+enabled_hardware_types = ipmi,idrac,irmc,fake-hardware,redfish,ibmc,manual-management,ilo,ilo5
+enabled_inspect_interfaces = inspector,idrac,irmc,fake,redfish,ilo


enabled_inspect_interfaces and enabled_power_interfaces do not support ilo5 ?

By the look of it, there is no 'ilo5' inspect or power interface, and instead the ilo5 hardware type supports 'ilo' for these interfaces by inheritance.

https://github.com/openstack/ironic/blob/8604f84fd7bda4e30d3f07005c4901f3662303a7/ironic/drivers/ilo.py#L74

This is also mentioned in the Ironic documentation on this page: https://docs.openstack.org/ironic/latest/admin/drivers/ilo.html

The ilo5 hardware type supports all the ilo interfaces [...] except for boot and raid interfaces.

Corrent. iLO5 is a subclass of iLO.

hardys · 2021-03-22T10:04:27Z

/lgtm

…-20211210 Merge metal3io master 20211210

metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 12, 2021

metal3-io-bot requested review from dhellmann and dtantsur March 12, 2021 08:16

macaptain changed the title ~~Support iLO4 and iLO5 BMCs~~ WIP: Support iLO4 and iLO5 BMCs Mar 12, 2021

metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2021

macaptain commented Mar 12, 2021

View reviewed changes

config/ironic.conf.j2 Show resolved Hide resolved

macaptain changed the title ~~WIP: Support iLO4 and iLO5 BMCs~~ Support iLO4 and iLO5 BMCs Mar 15, 2021

metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2021

dtantsur requested changes Mar 15, 2021

View reviewed changes

Support iLO4 and iLO5 BMCs

9af7066

This change adds configuration for the iLO driver as per https://docs.openstack.org/ironic/latest/admin/drivers/ilo.html The hardware interfaces for ilo are added to ironic.conf.j2 and the python3-proliantutils dependency has also been added.

dtantsur approved these changes Mar 15, 2021

View reviewed changes

metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2021

macaptain force-pushed the add-ilo-support branch from f005726 to 9af7066 Compare March 15, 2021 13:58

maelk reviewed Mar 15, 2021

View reviewed changes

dtantsur requested a review from maelk March 19, 2021 13:53

metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2021

metal3-io-bot merged commit c3b4bd9 into metal3-io:master Mar 22, 2021

hardys mentioned this pull request Mar 22, 2021

Ironic does not support ilo5 #243

Closed

macaptain deleted the add-ilo-support branch March 22, 2021 16:48

elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request Dec 13, 2021

Merge pull request metal3-io#244 from openshift/merge-metal3io-master…

8a0c4fd

…-20211210 Merge metal3io master 20211210

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support iLO4 and iLO5 BMCs #244

Support iLO4 and iLO5 BMCs #244

macaptain commented Mar 12, 2021 •

edited

Loading

fmuyassarov commented Mar 12, 2021

macaptain commented Mar 12, 2021 •

edited

Loading

dtantsur commented Mar 12, 2021

macaptain commented Mar 15, 2021

fmuyassarov commented Mar 15, 2021

dtantsur Mar 15, 2021

macaptain Mar 15, 2021

metal3-io-bot commented Mar 15, 2021

dtantsur commented Mar 15, 2021

dtantsur commented Mar 15, 2021

maelk Mar 15, 2021

macaptain Mar 15, 2021

dtantsur Mar 16, 2021

hardys commented Mar 22, 2021

Support iLO4 and iLO5 BMCs #244

Support iLO4 and iLO5 BMCs #244

Conversation

macaptain commented Mar 12, 2021 • edited Loading

fmuyassarov commented Mar 12, 2021

macaptain commented Mar 12, 2021 • edited Loading

dtantsur commented Mar 12, 2021

macaptain commented Mar 15, 2021

fmuyassarov commented Mar 15, 2021

dtantsur Mar 15, 2021

Choose a reason for hiding this comment

macaptain Mar 15, 2021

Choose a reason for hiding this comment

metal3-io-bot commented Mar 15, 2021

dtantsur commented Mar 15, 2021

dtantsur commented Mar 15, 2021

maelk Mar 15, 2021

Choose a reason for hiding this comment

macaptain Mar 15, 2021

Choose a reason for hiding this comment

dtantsur Mar 16, 2021

Choose a reason for hiding this comment

hardys commented Mar 22, 2021

macaptain commented Mar 12, 2021 •

edited

Loading

macaptain commented Mar 12, 2021 •

edited

Loading