Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote Iury to approvers, remove Stephen #355

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Promote Iury to approvers, remove Stephen #355

merged 1 commit into from
Feb 23, 2022

Conversation

dtantsur
Copy link
Member

Iury is the Ironic PTL (project team lead) and has been consistently
reviewing ironic-image changes in his reviewer role.

Stephen has moved to another role.

@dtantsur
Promote Iury to approvers, remove Stephen
b4b0daf 
Iury is the Ironic PTL (project team lead) and has been consistently
reviewing ironic-image changes in his reviewer role.

Stephen has moved to another role.
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2022
@dtantsur
Copy link
Member Author

/test-v1b1-ubuntu-integration

@dtantsur
Copy link
Member Author

/cc @elfosardo @derekhiggins @iurygregory

@furkatgofurov7
Copy link
Member

/test-v1b1-ubuntu-integration

@elfosardo
Copy link
Member

we need #354 to fix the ironic image build

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2022
@furkatgofurov7
Copy link
Member

we need #354 to fix the ironic image build

354 is merged now.

/test-v1b1-ubuntu-integration

@derekhiggins
Copy link
Member

lgtm
holding back the / to all others to vote

@dtantsur
Copy link
Member Author

We don't really need everyone to vote, the email thread was conclusive enough with a simple majority.

@derekhiggins
Copy link
Member

derekhiggins commented Feb 23, 2022 •
edited

/lgtm

We don't really need everyone to vote, the email thread was conclusive enough with a simple majority.

ack

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2022
@metal3-io-bot metal3-io-bot merged commit da91d4f into metal3-io:main Feb 23, 2022
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request Apr 13, 2023
@openshift-merge-robot
Merge pull request metal3-io#355 from dtantsur/OCPBUGS-10343
78226b6 
OCPBUGS-10343: allow inspector to also be proxied
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elfosardo elfosardo elfosardo approved these changes

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

@iurygregory iurygregory Awaiting requested review from iurygregory

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtantsur @furkatgofurov7 @elfosardo @metal3-io-bot @derekhiggins