Let Ironic handle retry instead of ipmitool

[lentzi90]

There seems to be an issue where ipmitool does not retry with different
ciphers. This could be worked around by letting Ironic handle the retry
instead.

Discussion on slack: https://kubernetes.slack.com/archives/CHD49TLE7/p1645523770977829

Here is a description of the issue we are having:

We have a (very old) hardware where IPMI cipher suite 3 is supported, but not 17. Due to

ironic-image/ironic-config/ironic.conf.j2

Line 140 in 307e765

use_ipmitool_retries = true

, we let ipmitool handle the retry loop. but then ipmitool only uses cipher 17 (we don't have ipmitool/ipmitool@7772254 in our ipmitool release). Due to https://github.com/openstack/ironic/blob/53a38f18d47d3fef5e9a7a8f6ecf5ab99b2f8e0f/ironic/drivers/modules/ipmitool.py#L662, Ironic does not handle the retry loop and does not actually change the ciphers that we provide in

ironic-image/ironic-config/ironic.conf.j2

Line 154 in 307e765

cipher_suite_versions = 3,17

. So that last setting has no effect. The question is then : What would be the impact of changing the config to let Ironic handle the retry loop? Would there be any inconvenient vs using ipmitool to do the retries?

[lentzi90]

/test-v1b1-ubuntu-integration

[dtantsur]

/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dtantsur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[namnx228]

/lgtm