Do not use hard coded Python 2 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfournie
approved these changes
Jun 11, 2019
juliakreger
reviewed
Jun 11, 2019
runironic.sh
Outdated
| /usr/bin/python2 /usr/bin/ironic-conductor --log-file /shared/log/ironic/ironic-conductor.log & | ||
| /usr/bin/python2 /usr/bin/ironic-api --log-file /shared/log/ironic/ironic-api.log & | ||
| /usr/bin/python /usr/bin/ironic-conductor --log-file /shared/log/ironic/ironic-conductor.log & | ||
| /usr/bin/python /usr/bin/ironic-api --log-file /shared/log/ironic/ironic-api.log & |
There was a problem hiding this comment.
so we shouldn't need to directly invoke with python on the path as PBR generates the script it includes a "#!/usr/bin/python". Ultimately we should want to shift to python3, but I'm guessing this is one of the areas current support in centos is problematic to build the images :\
There was a problem hiding this comment.
I actually did a test with Python 3.x but it was not very successful :/
and yes, you're right, I should just remove the python binary invocation
elfosardo
force-pushed
the
use-generic-python
branch
from
6dfb40b
to
e35e4c5
Compare
dtantsur
approved these changes
Jun 12, 2019
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/733/ |
|
@elfosardo could you rename your fork repo to ironic-image? The CI is pretty picky about names. |
|
@dtantsur sure thing! done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19