Stop defining inspection kernel params in ironic-image #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After metal3-io/ironic-inspector-image#25 these parameters are distributed via mDNS. Duplicating them here is confusing, since this image is supposed to be for ironic.
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/755/ |
bfournie
approved these changes
Jun 17, 2019
elfosardo
approved these changes
Jun 18, 2019
elfosardo
pushed a commit
to elfosardo/ironic-image
that referenced
this pull request
Mar 5, 2020
Add schema to bootloader setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After metal3-io/ironic-inspector-image#25
these parameters are distributed via mDNS. Duplicating them here is
confusing, since this image is supposed to be for ironic.