Changes to use Ironic Stein #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtantsur
requested changes
Jul 22, 2019
This was referenced Jul 22, 2019
elfosardo
force-pushed
the
use-ironic-stein
branch
from
891e064
to
885e7ba
Compare
elfosardo
changed the title
elfosardo
force-pushed
the
use-ironic-stein
branch
2 times, most recently
from
8251fb5
to
c300f05
Compare
iurygregory
suggested changes
Jul 22, 2019
There was a problem hiding this comment.
https://github.com/metal3-io/ironic-image/blob/master/runironic.sh#L29 - remove the call for the exporter here and also the runexporterapp file https://github.com/metal3-io/ironic-image/blob/master/runexporterapp.sh
ironic.conf
Outdated
| @@ -27,7 +27,6 @@ deploy_logs_local_path = /shared/log/ironic/deploy | |||
|
|
|||
| [conductor] | |||
| automated_clean = true | |||
| enable_mdns = True | |||
| send_sensor_data = true | |||
There was a problem hiding this comment.
send_sensor_data = true won't be necessary since we won't have the exporter
elfosardo
force-pushed
the
use-ironic-stein
branch
from
c300f05
to
bdb7a89
Compare
|
@dtantsur @iurygregory thanks and done all! |
elfosardo
force-pushed
the
use-ironic-stein
branch
from
bdb7a89
to
d3f935c
Compare
juliakreger
approved these changes
Jul 22, 2019
|
Looks good to me. @iurygregory @dtantsur If one of you can double check, I'll go ahead and push the merge button. |
|
This cannot merge before openshift-metal3/dev-scripts#680 |
dtantsur
requested changes
Jul 23, 2019
This patch contains changes needed to be able to use Ironic Stein. It has dependencies from other patches in other related repos. Full list of patches provided in PR.
elfosardo
force-pushed
the
use-ironic-stein
branch
from
d3f935c
to
59da58f
Compare
dtantsur
approved these changes
Jul 23, 2019
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/920/ |
bfournie
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch contains changes needed to be able to use Ironic Stein.
It has dependencies from other patches in other related repos
and they should all be merged at the same time, following the order below,
to guarantee a correct behavior.
Full patch set:
openshift-metal3/dev-scripts#680
#79
metal3-io/ironic-inspector-image#30
metal3-io/ironic-ipa-downloader#3