Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor upgrade tests for k8s #696

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Refactor upgrade tests for k8s #696

merged 1 commit into from
Jul 29, 2021

Conversation

lentzi90
Copy link
Member

  • Use k8s and k8s_info modules instead of shell
  • Use label selectors instead of greping for patterns

Note: This still has the CAPI version hard-coded to v1alpha3 while waiting for v1alpha4 to land.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 15, 2021
@lentzi90 lentzi90 force-pushed the refactor-k8s-upgrade/lennart branch from 94506b2 to b682c72 Compare June 17, 2021 05:42
@lentzi90
Copy link
Member Author

/test-integration
/test-v1a4-centos-integration

@lentzi90
Copy link
Member Author

/test-upgrade-features

@lentzi90 lentzi90 force-pushed the refactor-k8s-upgrade/lennart branch from b682c72 to bd1d7ad Compare June 17, 2021 10:08
@lentzi90
Copy link
Member Author

/test-upgrade-features

@lentzi90 lentzi90 force-pushed the refactor-k8s-upgrade/lennart branch from bd1d7ad to 84aac01 Compare June 17, 2021 11:19
@lentzi90
Copy link
Member Author

/test-upgrade-features

@lentzi90 lentzi90 force-pushed the refactor-k8s-upgrade/lennart branch from 84aac01 to 4c6bf47 Compare June 17, 2021 12:27
@lentzi90
Copy link
Member Author

/test-upgrade-features

@lentzi90 lentzi90 force-pushed the refactor-k8s-upgrade/lennart branch from 4c6bf47 to a3d7602 Compare June 18, 2021 04:46
@lentzi90
Copy link
Member Author

/test-upgrade-features

1 similar comment
@lentzi90
Copy link
Member Author

/test-upgrade-features

@lentzi90
Copy link
Member Author

/test-integration
/test-v1a4-centos-integration

1 similar comment
@lentzi90
Copy link
Member Author

/test-integration
/test-v1a4-centos-integration

@lentzi90
Copy link
Member Author

/test-v1a4-centos-integration

@lentzi90 lentzi90 force-pushed the refactor-k8s-upgrade/lennart branch 2 times, most recently from f6665bb to 6280843 Compare July 1, 2021 11:42
@lentzi90
Copy link
Member Author

lentzi90 commented Jul 5, 2021

/test-upgrade-features

@lentzi90 lentzi90 force-pushed the refactor-k8s-upgrade/lennart branch 4 times, most recently from 21a473f to 135d284 Compare July 5, 2021 12:30
@lentzi90
Copy link
Member Author

lentzi90 commented Jul 6, 2021

/test-upgrade-features

1 similar comment
@lentzi90
Copy link
Member Author

lentzi90 commented Jul 6, 2021

/test-upgrade-features

@lentzi90 lentzi90 force-pushed the refactor-k8s-upgrade/lennart branch 2 times, most recently from 567581d to 78fa75d Compare July 6, 2021 12:12
@lentzi90
Copy link
Member Author

lentzi90 commented Jul 6, 2021

/test-upgrade-features

@lentzi90 lentzi90 force-pushed the refactor-k8s-upgrade/lennart branch from 78fa75d to e5fd003 Compare July 8, 2021 06:06
@lentzi90 lentzi90 force-pushed the refactor-k8s-upgrade/lennart branch from 3038557 to 65bcfba Compare July 16, 2021 06:49
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2021
@lentzi90
Copy link
Member Author

/hold cancel
/test-integration
/test-v1a4-centos-integration
/test-upgrade-features

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2021
@lentzi90
Copy link
Member Author

/test-upgrade-features

1 similar comment
@lentzi90
Copy link
Member Author

/test-upgrade-features

@lentzi90 lentzi90 force-pushed the refactor-k8s-upgrade/lennart branch from 65bcfba to 1ec1878 Compare July 16, 2021 12:00
@lentzi90
Copy link
Member Author

/test-integration
/test-v1a4-centos-integration
/test-upgrade-features

@mboukhalfa
Copy link
Member

/test-upgrade-features

2 similar comments
@mboukhalfa
Copy link
Member

/test-upgrade-features

@mboukhalfa
Copy link
Member

/test-upgrade-features

@mboukhalfa mboukhalfa force-pushed the refactor-k8s-upgrade/lennart branch from 1a0e4d7 to 03ea597 Compare July 21, 2021 11:22
@mboukhalfa
Copy link
Member

/test-upgrade-features

1 similar comment
@mboukhalfa
Copy link
Member

/test-upgrade-features

@mboukhalfa mboukhalfa force-pushed the refactor-k8s-upgrade/lennart branch from 03ea597 to bd0b45d Compare July 21, 2021 16:00
@mboukhalfa
Copy link
Member

/test-upgrade-features

mboukhalfa
mboukhalfa reviewed Jul 21, 2021
View reviewed changes
vm-setup/roles/v1aX_integration_test/tasks/upgrade.yml
#
# Issues that may be related
# - https://github.com/kubernetes-client/python/issues/1402
# - https://github.com/kubernetes-client/python/issues/602
- name: Verify that controlplane nodes using the new node image
Copy link
Member

@mboukhalfa mboukhalfa Jul 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tricky. The control plane nodes are being replaced one by one.
this naturally causes some interruptions in the communication with the API.
Unfortunately it seems like the k8s_info module can get stuck in these
situations (i.e. it doesn't fail, it just hangs).
Ref ansible/ansible#30411

Attempted workarounds:

Issues that may be related

@mboukhalfa mboukhalfa force-pushed the refactor-k8s-upgrade/lennart branch from bd0b45d to b134d44 Compare July 21, 2021 21:19
@mboukhalfa
Copy link
Member

/test-integration
/test-v1a4-centos-integration
/test-upgrade-features

@mboukhalfa
Copy link
Member

/test-centos-integration
/test-features

@mboukhalfa
Copy link
Member

/assign @fmuyassarov

@macaptain
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2021
@fmuyassarov
Copy link
Member

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2021
@metal3-io-bot metal3-io-bot merged commit 598dce7 into metal3-io:master Jul 29, 2021
@lentzi90 lentzi90 deleted the refactor-k8s-upgrade/lennart branch February 11, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xenwar Xenwar Xenwar left review comments

@mboukhalfa mboukhalfa mboukhalfa left review comments

Assignees

@fmuyassarov fmuyassarov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lentzi90 @mboukhalfa @macaptain @fmuyassarov @metal3-io-bot @Xenwar