Skip to content

Document client-side timeouts in watch #1402

Closed

Description

@WouldYouKindly

Hi!

From the watch example it is not clear that timeout_seconds is a server-side timeout, and that the client will hang indefinitely in case of a network failure. I found out about this from this comment after we experienced the issue in my team.

I suggest documenting this in the watch example.

Activity

  1. roycaihw commented on Mar 29, 2021

    @roycaihw
    Member
  2. Priyankasaggu11929 commented on Apr 28, 2021

    @Priyankasaggu11929
    Contributor

    @roycaihw, can I work on updating the documentation around this? Taking reference information from this comment here #1148 (comment).

    Thank you!

  3. roycaihw commented on May 11, 2021

    @roycaihw
    Member

    @Priyankasaggu11929 Sorry for the late reply. Yes, I think that will be helpful! The comment looks correct to me.

    /assign @Priyankasaggu11929

  4. WouldYouKindly commented on Jul 16, 2021

    @WouldYouKindly
    Author

    Thank you both very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

kind/documentationCategorizes issue or PR as related to documentation.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions