Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document client-side timeouts in watch #1402

Closed
WouldYouKindly opened this issue Mar 23, 2021 · 4 comments · Fixed by #1467
Closed

Document client-side timeouts in watch #1402

WouldYouKindly opened this issue Mar 23, 2021 · 4 comments · Fixed by #1467
Assignees
Labels
kind/documentation Categorizes issue or PR as related to documentation.

Comments

@WouldYouKindly
Copy link

Hi!

From the watch example it is not clear that timeout_seconds is a server-side timeout, and that the client will hang indefinitely in case of a network failure. I found out about this from this comment after we experienced the issue in my team.

I suggest documenting this in the watch example.

@WouldYouKindly WouldYouKindly added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 23, 2021
@roycaihw
Copy link
Member

cc @roycaihw

@Priyankasaggu11929
Copy link
Contributor

@roycaihw, can I work on updating the documentation around this? Taking reference information from this comment here #1148 (comment).

Thank you!

@roycaihw
Copy link
Member

@Priyankasaggu11929 Sorry for the late reply. Yes, I think that will be helpful! The comment looks correct to me.

/assign @Priyankasaggu11929

@WouldYouKindly
Copy link
Author

Thank you both very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants