Add proposal for supporting external introspection #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
approved
dhellmann
reviewed
Jan 6, 2021
hardys
force-pushed
the
disable_inspection
branch
from
2559a71
to
415501e
Compare
metal3-io-bot
added
size/L
hardys
force-pushed
the
disable_inspection
branch
from
415501e
to
dd21880
Compare
|
/retitle Add proposal for supporting external introspection |
metal3-io-bot
changed the title
|
@dhellmann @andfasano updated based on your feedback, thanks! |
zaneb
reviewed
Jan 22, 2021
dhellmann
reviewed
Jan 22, 2021
andfasano
reviewed
Jan 25, 2021
hardys
pushed a commit
to hardys/baremetal-operator
that referenced
this pull request
Feb 4, 2021
When inspect.metal3.io=disabled is specified as an annotation we skip inspection and return complete immediately from the Inspecting state. Partially-Implements: metal3-io/metal3-docs#155
hardys
pushed a commit
to hardys/baremetal-operator
that referenced
this pull request
Feb 15, 2021
As described in metal3-io/metal3-docs#155 This enables addition of only the hardware part of the status, unlike the status annotation which can only be set on the first reconcile, since it allows all fields of the status to be modified.
hardys
force-pushed
the
disable_inspection
branch
4 times, most recently
from
89ba787
to
86ca369
Compare
andfasano
reviewed
Feb 23, 2021
hardys
pushed a commit
to hardys/baremetal-operator
that referenced
this pull request
Feb 25, 2021
As described in metal3-io/metal3-docs#155 This enables addition of only the hardware part of the status, unlike the status annotation which can only be set on the first reconcile, since it allows all fields of the status to be modified.
Add a proposal for an API to optionally disable introspection and update hardware status from some external inspection data if such data exists.
hardys
force-pushed
the
disable_inspection
branch
from
86ca369
to
03a5158
Compare
hardys
pushed a commit
to hardys/baremetal-operator
that referenced
this pull request
Mar 1, 2021
As described in metal3-io/metal3-docs#155 This enables addition of only the hardware part of the status, unlike the status annotation which can only be set on the first reconcile, since it allows all fields of the status to be modified.
hardys
pushed a commit
to hardys/baremetal-operator
that referenced
this pull request
Mar 1, 2021
As described in metal3-io/metal3-docs#155 This enables addition of only the hardware part of the status, unlike the status annotation which can only be set on the first reconcile, since it allows all fields of the status to be modified.
hardys
pushed a commit
to hardys/baremetal-operator
that referenced
this pull request
Mar 1, 2021
As described in metal3-io/metal3-docs#155 This enables addition of only the hardware part of the status, unlike the status annotation which can only be set on the first reconcile, since it allows all fields of the status to be modified.
hardys
pushed a commit
to hardys/baremetal-operator
that referenced
this pull request
Mar 2, 2021
As described in metal3-io/metal3-docs#155 This enables addition of only the hardware part of the status, unlike the status annotation which can only be set on the first reconcile, since it allows all fields of the status to be modified.
hardys
pushed a commit
to hardys/baremetal-operator
that referenced
this pull request
Mar 2, 2021
As described in metal3-io/metal3-docs#155 This enables addition of only the hardware part of the status, unlike the status annotation which can only be set on the first reconcile, since it allows all fields of the status to be modified.
|
I'm happy with this draft. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, hardys The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hardys
pushed a commit
to hardys/baremetal-operator
that referenced
this pull request
Mar 3, 2021
As described in metal3-io/metal3-docs#155 This enables addition of only the hardware part of the status, unlike the status annotation which can only be set on the first reconcile, since it allows all fields of the status to be modified.
hardys
pushed a commit
to hardys/baremetal-operator
that referenced
this pull request
Mar 4, 2021
As described in metal3-io/metal3-docs#155 This enables addition of only the hardware part of the status, unlike the status annotation which can only be set on the first reconcile, since it allows all fields of the status to be modified.
hardys
pushed a commit
to hardys/baremetal-operator
that referenced
this pull request
Mar 4, 2021
Adds documentation for these interfaces, more information can be found in metal3-io/metal3-docs#155
rdoxenham
pushed a commit
to rdoxenham/baremetal-operator
that referenced
this pull request
Mar 8, 2021
When inspect.metal3.io=disabled is specified as an annotation we skip inspection and return complete immediately from the Inspecting state. Partially-Implements: metal3-io/metal3-docs#155
hardys
pushed a commit
to hardys/baremetal-operator
that referenced
this pull request
Mar 8, 2021
Adds documentation for these interfaces, more information can be found in metal3-io/metal3-docs#155
hardys
pushed a commit
to hardys/baremetal-operator
that referenced
this pull request
Mar 9, 2021
As described in metal3-io/metal3-docs#155 This enables addition of only the hardware part of the status, unlike the status annotation which can only be set on the first reconcile, since it allows all fields of the status to be modified.
hardys
pushed a commit
to hardys/baremetal-operator
that referenced
this pull request
Mar 9, 2021
Adds documentation for these interfaces, more information can be found in metal3-io/metal3-docs#155
hardys
pushed a commit
to hardys/baremetal-operator
that referenced
this pull request
Mar 9, 2021
As described in metal3-io/metal3-docs#155 This enables addition of only the hardware part of the status, unlike the status annotation which can only be set on the first reconcile, since it allows all fields of the status to be modified.
hardys
pushed a commit
to hardys/baremetal-operator
that referenced
this pull request
Mar 9, 2021
Adds documentation for these interfaces, more information can be found in metal3-io/metal3-docs#155
|
This was discussed in the community meeting today, we agreed to give a week for lazy-consensus and merge if there are no objections. |
|
Ok the lazy consensus period completed and there were no objections - @andfasano perhaps you can add the lgtm please? |
|
/lgtm |
|
@andfasano: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dhellmann @maelk perhaps you could merge this? Seems we have a small list of approvers in the OWNERS, we should look at expanding that. |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a proposal for an API to optionally disable introspection - this is related to the LiveImage proposal, where we may wish to skip inspection either to boot an appliance image faster, or because the image booted does it's own inspection.