Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce general security policy for Metal3-io #293

Merged
merged 1 commit into from Nov 4, 2022

Conversation

Rozzii
Copy link
Member

@Rozzii Rozzii commented Nov 4, 2022

No description provided.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2022
@Rozzii
Copy link
Member Author

Rozzii commented Nov 4, 2022

/retest

@kashifest
Copy link
Member

/assign @tuminoid

@Rozzii
Copy link
Member Author

Rozzii commented Nov 4, 2022

/retest

1 similar comment
@Rozzii
Copy link
Member Author

Rozzii commented Nov 4, 2022

/retest

@Rozzii Rozzii force-pushed the security_policy branch 3 times, most recently from 0f8192a to 0f672d6 Compare November 4, 2022 09:47
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This policy closely follows Kubernetes' policy simplified where due, and besides minor corrections I have no further objections at this time.

docs/user-guide/src/security_policy.md Outdated Show resolved Hide resolved
docs/user-guide/src/security_policy.md Outdated Show resolved Hide resolved
docs/user-guide/src/security_policy.md Outdated Show resolved Hide resolved
docs/user-guide/src/security_policy.md Outdated Show resolved Hide resolved
@Rozzii
Copy link
Member Author

Rozzii commented Nov 4, 2022

/cc @zaneb @dtantsur @elfosardo @lentzi90

@tuminoid
Copy link
Member

tuminoid commented Nov 4, 2022

lgtm after the fixes

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2022
@Rozzii Rozzii requested review from lentzi90 and removed request for dtantsur, zaneb, elfosardo and smoshiur1237 November 4, 2022 12:59
@Rozzii
Copy link
Member Author

Rozzii commented Nov 4, 2022

/retest

1 similar comment
@Rozzii
Copy link
Member Author

Rozzii commented Nov 4, 2022

/retest

@dtantsur
Copy link
Member

dtantsur commented Nov 4, 2022

Looks good. Waiting for more reviews before landing, but feel free to consider this comment an lgtm from me whenever convenient.

@elfosardo
Copy link
Member

LGTM thanks!

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2022
@kashifest
Copy link
Member

/retest

1 similar comment
@Rozzii
Copy link
Member Author

Rozzii commented Nov 4, 2022

/retest

@kashifest
Copy link
Member

/test all

@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2022
@furkatgofurov7
Copy link
Member

Looks like this needs a force push to fix the Netlify issues?

@smoshiur1237
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2022
@metal3-io-bot metal3-io-bot merged commit e590362 into metal3-io:main Nov 4, 2022
@Rozzii Rozzii deleted the security_policy branch October 5, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants