Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest broken links update #335

Closed
wants to merge 3 commits into from
Closed

Latest broken links update #335

wants to merge 3 commits into from

Conversation

SafeEHA
Copy link
Contributor

@SafeEHA SafeEHA commented Jun 20, 2023 •
edited
Loading

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 20, 2023
@metal3-io-bot
Copy link
Contributor

Hi @SafeEHA. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 20, 2023
@tuminoid
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 20, 2023
tuminoid
tuminoid reviewed Jun 20, 2023
View reviewed changes
design/baremetal-operator/implicit-boot-mode.md Outdated
@@ -106,7 +106,7 @@ that is also easy to document.
The proposal, therefore, is to always use BIOS mode when using IPMI
and to prefer UEFI when using Redfish. We can implement this by adding
a new method to the [AccessDetails
interface](https://github.com/metal3-io/baremetal-operator/blob/main/pkg/bmc/access.go#L27)
interface](https://github.com/metal3-io/baremetal-operator/blob/dabe5e14bafa00db6ccb37f1169c74ee3dac4425/pkg/hardwareutils/bmc/access.go)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the line reference, update to point to correct line as needed.

design/baremetal-operator/implicit-boot-mode.md Outdated Show resolved Hide resolved
tuminoid
tuminoid reviewed Jun 20, 2023
View reviewed changes
design/baremetal-operator/implicit-boot-mode.md Outdated
@@ -106,7 +106,7 @@ that is also easy to document.
The proposal, therefore, is to always use BIOS mode when using IPMI
and to prefer UEFI when using Redfish. We can implement this by adding
a new method to the [AccessDetails
interface](https://github.com/metal3-io/baremetal-operator/blob/dabe5e14bafa00db6ccb37f1169c74ee3dac4425/pkg/hardwareutils/bmc/access.go)
interface](https://github.com/metal3-io/baremetal-operator/blob/dabe5e14bafa00db6ccb37f1169c74ee3dac4425/pkg/hardwareutils/bmc/access.go#L27)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AccessDetails interface is starting at L47.

design/baremetal-operator/implicit-boot-mode.md Outdated
@@ -141,7 +141,7 @@ values later for other hardware platforms.
## Design Details

- Update the [AccessDetails
interface](https://github.com/metal3-io/baremetal-operator/blob/dabe5e14bafa00db6ccb37f1169c74ee3dac4425/pkg/hardwareutils/bmc/access.go)
interface](https://github.com/metal3-io/baremetal-operator/blob/dabe5e14bafa00db6ccb37f1169c74ee3dac4425/pkg/hardwareutils/bmc/access.go#L27)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, i would make the correction now

tuminoid and others added 2 commits June 20, 2023 14:00
@tuminoid @SafeEHA
add releasing.md
000893f 
Describe the release process to release Metal3, ie. CAPM3 with latest
IPAM and BMO. This process then points to newly updates releasing.md
in each of the components.
@SafeEHA
more broken links fix
8356770
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zaneb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 20, 2023
@metal3-io-bot
Copy link
Contributor

@SafeEHA: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
markdownlint dc1fdb8 link true /test markdownlint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SafeEHA SafeEHA closed this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

Assignees
No one assigned
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SafeEHA @metal3-io-bot @tuminoid