Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release-1.7 support #413

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Apr 12, 2024

/hold

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 12, 2024
@mquhuy mquhuy force-pushed the mquhuy/add-release-1.7 branch 2 times, most recently from b102a18 to 5b3ef2f Compare April 12, 2024 13:39
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@kashifest
Copy link
Member

/lgtm cancel

@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@kashifest
Copy link
Member

I have approved it already, please someone else take a look

@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@@ -83,16 +86,16 @@ The table describes which branches/image-tags are tested in each periodic CI tes
| ------------------------------------------------ | ------------ | ----------- | -------------- | -------------- | ----------- | ---------- |
| daily_main_integration_test_ubuntu/centos | main | main | main | latest | latest | latest |
| daily_main_e2e_integration_test_ubuntu/centos | main | main | main | latest | latest | latest |
| daily_release-1-7_integration_test_ubuntu/centos | release-1.7 | release-1.7 | release-0.6 | v0.6.0 | latest | latest |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This table seems outdated we are now using e2e tests as main tests can we update the table before merging the PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the job naming also changed recently

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Does it look ok now?

Signed-off-by: Huy Mai <huy.mai@est.tech>
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Apr 22, 2024

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2024
@metal3-io-bot metal3-io-bot merged commit b1a6f28 into metal3-io:main Apr 22, 2024
8 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/add-release-1.7 branch April 22, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants