Add docker-build target #425
Conversation
metal3-io-bot
added
the
size/M
|
It seems like we have not published a new container image for this in ~2 years. How about we just always build it locally? I don't see much need for publishing this image and if we always build locally there is one less thing to worry about. |
|
/cc @peppi-lotta |
|
Excellent change in my opinion! Works great. /lgtm |
|
@peppi-lotta: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
It doesn't seem to work unless built with |
|
Sure I can add some default version! |
This adds a docker-build make target for building the container image. The Dockerfile is also expanded to build the releasetags preprocessor in a build container instead of copying from the host. The mdbook version is taken from the Makfile as an argument. The rust version is bumped since the old version could not build the newer mdbook version. (The versions in the Dockerfile and Makefile were different.) Signed-off-by: Lennart Jern <lennart.jern@est.tech>
lentzi90
force-pushed
the
lentzi90/docker-build
branch
from
68f85ad
to
adf7745
Compare
|
/cc @kashifest @dtantsur |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
This adds a docker-build make target for building the container image. The Dockerfile is also expanded to build the releasetags preprocessor in a build container instead of copying from the host.
The mdbook version is taken from the Makfile as an argument. The rust version is bumped since the old version could not build the newer mdbook version. (The versions in the Dockerfile and Makefile were different.)