Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User guide: migrate BMC addressing information from BMO #428

Merged
merged 1 commit into from
May 20, 2024

Conversation

dtantsur
Copy link
Member

Adds a new page "Supported hardware" with information loosely based on
the BMO docs with these modifications:

  • Split one large table into sections based on the underlying
    technology.
  • Copy supported Dell firmware versions from OpenShift docs.
  • Write clarifications on Redfish support status.
  • Highlight supporting iLO 6.
  • Highlight which iLO 5 drivers support hardware RAID.

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

Adds a new page "Supported hardware" with information loosely based on
the BMO docs with these modifications:
- Split one large table into sections based on the underlying
  technology.
- Copy supported Dell firmware versions from OpenShift docs.
- Write clarifications on Redfish support status.
- Highlight supporting iLO 6.
- Highlight which iLO 5 drivers support hardware RAID.

Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 16, 2024
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
It feels a bit weird to have this under Baremetal Operator, but I'm not convinced it should be a top level page either. In any case, I think the content is good. If someone has a better idea for placement, please speak up! In the mean time, I will approve this 🙂
/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@dtantsur
Copy link
Member Author

@lentzi90 my thinking was: this information is based on the code in baremetal-operator: both the URL format and the list of available drivers is defined there. So it's sort of a property of BareMetalHost API rather than something Metal3-wide (indeed, Ironic supports more drivers and uses a different format).

@lentzi90
Copy link
Member

That makes sense, but on the other hand it also propagates to CAPM3 since that builds on top of BMO. So CAPM3 won't work with any other hardware either.

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Great addition to the user guide, thanks!

network* for isolated L2 traffic between the Metal3 control plane and the
machines.

2. Virtual media boot. Some hardware model support directly booting an ISO 9660
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Virtual media boot. Some hardware model support directly booting an ISO 9660
1. Virtual media boot. Some hardware model support directly booting an ISO 9660

Markdown numbered lists are recommended to be a list of 1. as they will be auto numbered on rendering, removing the need of adjusting them if list length changes.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@metal3-io-bot metal3-io-bot merged commit 7e0594e into metal3-io:main May 20, 2024
8 checks passed
@dtantsur dtantsur deleted the drivers branch May 21, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants