-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for UEFI HTTP boot #459
base: main
Are you sure you want to change the base?
Conversation
b9f4584
to
81ab364
Compare
/cc @dtantsur |
61f2ea2
to
bceff1b
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks fine this feature would be a nice addition, I am a bit unclear on the config drive limitations as per my comment.
this case between `redfish-virtualmedia` and `redfish-uefihttp` since they both | ||
rely on network booting from an ISO image. | ||
In general, the main difference is that the UEFI HTTP boot supports Secure | ||
Boot, while virtual media does not, but on the other hand, no configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come no configuration drive functionality? Is it not possible to boot IPA thus not possible to send over the config drive via IPA API? or what do you men by no configuration drive functionality? Could you please clarify this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think Riccardo meant that, but I agree, it is confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, sorry for the confusion, I had to unconfuse myself too here!
this is not related to IPA at all
what I meant is that no static configuration can be injected at boot time, DHCP is a hard requirement
does that help?
Proposal to add support for UEFI HTTP boot adding a new hardware driver `redfish-http-boot` that uses the already implemented ironic `redfish-https` boot interface. Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
bceff1b
to
521dc43
Compare
Proposal to add support for UEFI HTTP boot adding a new hardware driver
redfish-uefihttp
that uses the already implemented ironicredfish-https
boot interface.