Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build diskimage builder from upstream commit until next release #768

Merged
merged 1 commit into from
May 28, 2024
Merged

Build diskimage builder from upstream commit until next release #768

merged 1 commit into from
May 28, 2024

Conversation

Sunnatillo
Copy link
Member

@Sunnatillo Sunnatillo commented May 22, 2024 •
edited
Loading

Centos image building is broken with wrong partition UUID error. Here is the fix in the upstream.
Until diskimage-builder is released, we need to built it from fix commit in master branch.

@metal3-io-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2024
@metal3-io-bot metal3-io-bot added needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 22, 2024
@Sunnatillo Sunnatillo force-pushed the centos-image-build-workaround branch 3 times, most recently from 43df31e to 3e56d05 Compare May 22, 2024 21:01
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2024
@Sunnatillo Sunnatillo force-pushed the centos-image-build-workaround branch from 3e56d05 to 3cd0a6c Compare May 23, 2024 10:57
@Sunnatillo Sunnatillo marked this pull request as ready for review May 27, 2024 11:49
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2024
@Sunnatillo Sunnatillo force-pushed the centos-image-build-workaround branch 2 times, most recently from 9beee49 to 42df912 Compare May 27, 2024 12:42
@Sunnatillo
Copy link
Member Author

/hold for testing

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2024
@Sunnatillo Sunnatillo force-pushed the centos-image-build-workaround branch 2 times, most recently from dd48bee to cc14dad Compare May 27, 2024 13:27
@Sunnatillo
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2024
@Sunnatillo
Copy link
Member Author

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@Sunnatillo: Overrode contexts on behalf of Sunnatillo: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

NymanRobin
NymanRobin reviewed May 27, 2024
View reviewed changes
Copy link
Member

@NymanRobin NymanRobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
/approve

jenkins/image_building/build-image.sh Show resolved Hide resolved
@Sunnatillo Sunnatillo force-pushed the centos-image-build-workaround branch from cc14dad to d5dab85 Compare May 27, 2024 16:45
@Sunnatillo Sunnatillo changed the title Build diskimage builder from upstream until next release Build diskimage builder from upstream commit until next release May 27, 2024
tuminoid
tuminoid reviewed May 27, 2024
View reviewed changes
jenkins/image_building/build-image.sh Outdated Show resolved Hide resolved
jenkins/image_building/build-image.sh Outdated Show resolved Hide resolved
jenkins/image_building/build-image.sh Outdated Show resolved Hide resolved
@Sunnatillo
Build diskimage builder from upstream until next release of DIB
70e7404 
Currently centos disk image build are broken with the partition
UUID issue: openstack/diskimage-builder@c03e46d
We are building DIB from fix commit.

Signed-off-by: Sunnatillo <sunnat.samadov@est.tech>
@Sunnatillo Sunnatillo force-pushed the centos-image-build-workaround branch from d5dab85 to 70e7404 Compare May 28, 2024 07:32
smoshiur1237
smoshiur1237 reviewed May 28, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2024
tuminoid
tuminoid reviewed May 28, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/hold
Unhold when you've manually verified the image with the latest changes.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2024
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NymanRobin, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2024
@Sunnatillo
Copy link
Member Author

manually tested here:
https://jenkins.nordix.org/view/Metal3%20Periodic/job/metal3_periodic_node_image_building/23/consoleFull

@Sunnatillo
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2024
@Sunnatillo
Copy link
Member Author

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@Sunnatillo: Overrode contexts on behalf of Sunnatillo: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot merged commit 48cc9ac into metal3-io:main May 28, 2024
6 checks passed
@Sunnatillo Sunnatillo deleted the centos-image-build-workaround branch May 28, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@NymanRobin NymanRobin NymanRobin left review comments

@kashifest kashifest Awaiting requested review from kashifest

@lentzi90 lentzi90 Awaiting requested review from lentzi90

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sunnatillo @metal3-io-bot @tuminoid @smoshiur1237 @NymanRobin