Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all E2E fileops tests to integration tests, leave single application with both agent types. #1032

Open
t4lz opened this issue Feb 8, 2023 · 0 comments
Labels
enhancement New feature or request tests

Comments

@t4lz
Copy link
Member

t4lz commented Feb 8, 2023

  • Remove the multi-value test argument from test_file_ops:

    #[values(FileOps::Python, FileOps::Rust)] ops: FileOps,

  • Use only the Rust app in E2E.

  • For Rust and Python: Create separate apps for read, write, lseek, and faccessat, like the go apps:

    Go18Read,
    Go19Read,
    Go20Read,
    Go18Write,
    Go19Write,
    Go20Write,
    Go18LSeek,
    Go19LSeek,
    Go20LSeek,
    Go18FAccessAt,
    Go19FAccessAt,
    Go20FAccessAt,

    (RustRead, PythonRead, RustWrite, etc.)

  • If we're lucky, those operations are similar in Rust, Python and Go and we can just add those apps to the existing tests for Go (and rename the tests), but more likely, we would have to create new tests for the new apps.

@t4lz t4lz added enhancement New feature or request tests labels Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests
Projects
None yet
Development

No branches or pull requests

1 participant