add use-ironic design document #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellb
reviewed
Feb 18, 2019
russellb
reviewed
Feb 18, 2019
dhellmann
force-pushed
the
use-ironic
branch
from
38a07e8
to
ed37aeb
Compare
russellb
reviewed
Feb 18, 2019
design/use-ironic.md
Outdated
| Giving the Pod host network access gives it the ability to see much | ||
| more of the host on which it is running. On the other hand, this is a | ||
| provisioning tool, and it's going to be writing images to hosts. So it | ||
| already has quite a lot of power. |
There was a problem hiding this comment.
Or maybe the future multus usage note should be here?
design/use-ironic.md
Outdated
| it means we have to somehow tell the operator where the two services | ||
| are so it can build a URL to communicate with them. It also means | ||
| something needs to manage the Pod running the services to ensure it is | ||
| present in the cluster when it is needed. |
There was a problem hiding this comment.
It also simplifies security concerns for the Ironic API
juliakreger
reviewed
Feb 18, 2019
|
LGTM, but would you like to squash this first? |
Start filling in some of the details about using Ironic. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
dhellmann
force-pushed
the
use-ironic
branch
from
042fa17
to
3ddba2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start filling in some of the details about using Ironic.
Signed-off-by: Doug Hellmann dhellmann@redhat.com