Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate API usage from *.metafi and *.metaswap subdomains to *.api.cx.metamask.io #4215

Closed
1 of 9 tasks
sethkfman opened this issue Apr 25, 2024 · 0 comments · Fixed by #4301
Closed
1 of 9 tasks

Migrate API usage from *.metafi and *.metaswap subdomains to *.api.cx.metamask.io #4215

sethkfman opened this issue Apr 25, 2024 · 0 comments · Fixed by #4301
Assignees
@cryptodev-2s
Labels
team-wallet-framework

Comments

@sethkfman
Copy link
Contributor

What is this about?

API Platform team intends to deprecate *.metafi and *.metaswap subdomains in favour of *.api.cx.metamask.io
The new *.api.cx.metamask.io is already in place.
The old *.metafi and *.metaswap are still used across the controllers.
Controllers do not break currently because redirects are in place for the older sub-domains.
The redirects will be removed once all clients (Extension, Mobile, Core) are migrated.

Scenario

  • NA

Design

  • NA

Technical Details

  • TBD

Threat Modeling Framework

  • NA

Acceptance Criteria

  • All occurrences of *.metafi and *.metaswap subdomains replaced by *.api.cx.metamask.io subdomain in the core codebase.

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References
@sethkfman sethkfman mentioned this issue Apr 25, 2024
Merged
6 tasks
@cryptodev-2s cryptodev-2s self-assigned this May 21, 2024
This was referenced May 21, 2024
Merged
Merged
cryptodev-2s added a commit that referenced this issue May 23, 2024
@cryptodev-2s
fix: Migrate API usage from *.metafi & *.metaswap subdomains to *.cx.…
d5e007b 
…metamsk.io" (#4301)

## Explanation

API Platform team intends to deprecate *.metafi and *.metaswap
subdomains in favour of *.api.cx.metamask.io
The new *.api.cx.metamask.io is already in place.
The old *.metafi and *.metaswap are still used across the controllers.
Controllers do not break currently because redirects are in place for
the older sub-domains.
The redirects will be removed once all clients (Extension, Mobile, Core)
are migrated.

## References

* Fixes #4215

## Changelog

### `@metamask/assets-controller`

- **CHANGED:** Update price API endpoint from
`price-api.metafi.codefi.network` to `price.api.cx.metamask.io`
- **CHANGED:** Update token icons API endpoint from
`*.metafi.codefi.network` to `*.cx.metamask.io`
- **CHANGED:** Update toke API endpoint from
`token-api.metaswap.codefi.network` to `token.api.cx.metamask.io`

### `@metamask/phishing-controller`

- **CHANGED:** Update phishing detection API endpoint from
`*.metafi.codefi.network` to `*.api.cx.metamask.io`

### `@metamask/controller-utils`

- **CHANGED:** Update OpenSea proxy endpoint from
`*.metafi.codefi.network` to `*.api.cx.metamask.io`

### `@metamask/name-controller`

- **CHANGED:** Update token API endpoint from
`token-api.metaswap.codefi.network` to `token.api.cx.metamask.io`

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cryptodev-2s cryptodev-2s

Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Migrate API usage from *.metafi & *.metaswap subdomains to *.cx.metamask.io" MetaMask/core
3 participants
@desi @sethkfman @cryptodev-2s