Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: MetaMask closes when attempting to pair with a Ledger that is locked OR with the screensaver showing #8716

Closed
plasmacorral opened this issue Feb 24, 2024 · 6 comments
Assignees
Labels
awaiting-fix-from-ledger Ledger Ledger hardware wallet related issue or development Priority - Medium Task with medium priority regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-7.17.0 release-7.17.0 Issue or pull request that will be included in release 7.17.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking stale Issues that have not had activity in the last 90 days team-hardware-wallets type-bug Something isn't working

Comments

@plasmacorral
Copy link
Contributor

plasmacorral commented Feb 24, 2024

Describe the bug

Observed in RC 7.17.0 with Pixel 5a Android 14 in build 1266. If I attempt to add hardware with the Ledger screensaver showing (or with no screensaver at the Enter PIN screen=device locked) then MetaMask will close. After the first failure, on retry the Ledger device drop down shows that a device with no name is selected. After the second attempt, I produce the MetaMask keeps stopping system message.

Expected behavior

Given that the Ledger device is locked regardless of whether its the PIN screen or screensaver
When I attempt to add hardware
And pairing cannot be completed
Then an actionable error message is presented to the user
And the app does not stop

Screenshots/Recordings

SecondAttemptToAddHardwareWhileScreensaverRunsAppCloses

https://recordit.co/JJ4QmYX0qC

Steps to reproduce

  1. Have Ledger device setup, with Ethereum app installed, address added, but screensaver showing (you can adjust this to 1 minute in Ledger settings) or just locked at the PIN entry screen
  2. Go to Android Settings>Connected devices and make sure Ledger is not currently paired. If it is, forget the device
  3. Check Settings>Location and make sure location is enabled
  4. Unlock MetaMask
  5. Initiate Add hardware flow
  6. Approve Location permission request
  7. Approve nearby device permission request
  8. On the Connect Ledger page, tap Continue while Ledger remains locked
  9. When pairing request is presented tap Pair & connect
  10. Note that MetaMask closes
  11. repeat steps 4-9 but note that this time around the drop down box that usually has the Ledger device name is blank and that system message is presented about MetaMask keeps stopping

Error messages or log output

No response

Version

7.17.0 RC1 build 1266

Build type

None

Device

Pixel 5a Android 14

Operating system

Android

Additional context

No response

Severity

No response

@plasmacorral plasmacorral added type-bug Something isn't working Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking Ledger Ledger hardware wallet related issue or development regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead team-hardware-wallets release-7.17.0 Issue or pull request that will be included in release 7.17.0 labels Feb 24, 2024
@plasmacorral plasmacorral changed the title [Bug]: MetaMask closes when attempting to pair with a Ledger that is locked with the screensaver showing [Bug]: MetaMask closes when attempting to pair with a Ledger that is locked OR with the screensaver showing Feb 24, 2024
@vivek-consensys vivek-consensys self-assigned this Feb 26, 2024
@vivek-consensys
Copy link
Contributor

vivek-consensys commented Feb 26, 2024

Tested using Samsung Android 13.
I am unable to replicate this issue, MM does not close when Ledger is locked. MM throws an error to unlock the Ledger device when locked and trying to connect:
image.png

@angelcheung22
Copy link

@plasmacorral we re unable to reproduce this issue.

@angelcheung22
Copy link

Leo to retest on Andriod 14, potentially version specific issue only

@angelcheung22
Copy link

Error coming from native level, cannot be really catch from our side, may or may not be fixed by the ledger firmware issue.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Aug 13, 2024
Copy link
Contributor

This issue was closed because there has been no follow activity in 7 days. If you feel this was closed in error please provide evidence on the current production app in a new issue or comment in the existing issue to a maintainer. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 20, 2024
@angelcheung22 angelcheung22 added this to the Q3 20204 CET HW milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-fix-from-ledger Ledger Ledger hardware wallet related issue or development Priority - Medium Task with medium priority regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-7.17.0 release-7.17.0 Issue or pull request that will be included in release 7.17.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking stale Issues that have not had activity in the last 90 days team-hardware-wallets type-bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

6 participants