Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove all remaining legacy analytics native code #8795

Closed
12 of 21 tasks
NicolasMassart opened this issue Mar 1, 2024 · 1 comment · Fixed by #8829
Closed
12 of 21 tasks

feat: remove all remaining legacy analytics native code #8795

NicolasMassart opened this issue Mar 1, 2024 · 1 comment · Fixed by #8829
Assignees
Labels
release-7.18.0 Issue or pull request that will be included in release 7.18.0 release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-mobile-platform

Comments

@NicolasMassart
Copy link
Contributor

NicolasMassart commented Mar 1, 2024

What is this about?

Since migration to new MetaMetrics using segment is done, we can remove all Mixpanel analytics native code and dependencies.

Scenario

No response

Design

No response

Technical Details

Android

  • Remove mixpanel native dependencies in android/app/build.gradle
  • all native module code in Android related to RCTAnalytics in android/app/src/main/java/io/metamask/nativeModules
  • MM_MIXPANEL_TOKEN in .android.env and gradle files

iOS

  • Remove mixpanel native dependencies in ios/mixpanel-iphone and ios/Mixpanel.framework
  • all native module code in iOS related to RCTAnalytics in ios/MetaMask/NativeModules/RCTAnalytics
  • all mixpanel code in ios
  • all framework link in ios/MetaMask.xcodeproj
  • ios/mixpanel-iphone git submodule
  • MM_MIXPANEL_TOKEN in plist files

Common

  • all mixpanel properties (search for mixpanel in all the project)
  • remove remapping MM_MIXPANEL_TOKEN in scripts/build.sh

Bitrise

Threat Modeling Framework

No response

Acceptance Criteria

  • no Mixpanel code remaining

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

@NicolasMassart NicolasMassart self-assigned this Mar 1, 2024
@metamaskbot metamaskbot added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed in-progress labels Mar 6, 2024
NicolasMassart added a commit that referenced this issue Mar 7, 2024
Remove all Mixpanel analytics native code and dependencies.
Fixes #8795
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 7, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 7, 2024
metamaskbot pushed a commit that referenced this issue Mar 8, 2024
Remove all Mixpanel analytics native code and dependencies.
Fixes #8795
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Mar 12, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-7.18.0 on issue. Adding release label release-7.18.0 on issue, as issue is linked to PR #8829 which has this release label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-7.18.0 Issue or pull request that will be included in release 7.18.0 release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-mobile-platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants