fix: Account for revoked origins in initialConnections
#2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2535 +/- ##
=======================================
Coverage 93.93% 93.94%
=======================================
Files 456 456
Lines 9535 9542 +7
Branches 1458 1458
=======================================
+ Hits 8957 8964 +7
Misses 578 578 ☔ View full report in Codecov by Sentry. |
david0xd
approved these changes
Jul 4, 2024
FrederikBolding
deleted the
fb/account-for-revoked-origins-in-initial-connections
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to account for revoked origins when calculating the difference in
initialConnections. Essentially, we don't need to revoke permissions that are already revoked and we want to show revoked connections as being re-added in the UI.Fixes #2532