fix useExplicitVersion (apache#3559)

metamx · Oct 10, 2016 · 1e79a1b · 1e79a1b
1 parent 3a83e05
commit 1e79a1b
Showing 1 changed file with 12 additions and 10 deletions.
diff --git a/indexing-service/src/main/java/io/druid/indexing/common/task/HadoopIndexTask.java b/indexing-service/src/main/java/io/druid/indexing/common/task/HadoopIndexTask.java
@@ -73,7 +73,7 @@ private static String getTheDataSource(HadoopIngestionSpec spec)
   /**
    * @param spec is used by the HadoopDruidIndexerJob to set up the appropriate parameters
    *             for creating Druid index segments. It may be modified.
-   *             <p>
+   *             <p/>
    *             Here, we will ensure that the DbConnectorConfig field of the spec is set to null, such that the
    *             job does not push a list of published segments the database. Instead, we will use the method
    *             IndexGeneratorJob.getPublishedSegments() to simply return a list of the published
@@ -204,15 +204,17 @@ public TaskStatus run(TaskToolbox toolbox) throws Exception
     }
 
     final String specVersion = indexerSchema.getTuningConfig().getVersion();
-    if (indexerSchema.getTuningConfig().isUseExplicitVersion() && version.compareTo(specVersion) > 0) {
-      version = specVersion;
-    } else {
-      log.error(
-          "Spec version can not be greater than lock version, Spec version: [%s] Lock version: [%s].",
-          specVersion,
-          version
-      );
-      return TaskStatus.failure(getId());
+    if (indexerSchema.getTuningConfig().isUseExplicitVersion()) {
+      if (specVersion.compareTo(version) < 0) {
+        version = specVersion;
+      } else {
+        log.error(
+            "Spec version can not be greater than or equal to the lock version, Spec version: [%s] Lock version: [%s].",
+            specVersion,
+            version
+        );
+        return TaskStatus.failure(getId());
+      }
     }
 
     log.info("Setting version to: %s", version);