Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate PDF setup into build script #38

Closed
opoudjis opened this issue Feb 10, 2020 · 7 comments
Closed

Integrate PDF setup into build script #38

opoudjis opened this issue Feb 10, 2020 · 7 comments
Assignees

Comments

@opoudjis
Copy link

Integrate instructions from https://github.com/metanorma/mn-native-pdf/blob/master/README.adoc, as we are now integrating the functionality of that repository into metanorma

@opoudjis
Copy link
Author

opoudjis commented Mar 2, 2020

An essential component of this work is to identify the fonts directory on the current system to be used for PDF generation. The README in mn-native-pdf is mac only.

@CAMOBAP
Copy link
Contributor

CAMOBAP commented Apr 5, 2020

@opoudjis @ronaldtse as far as I know globally we are going to replace puppeteer with https://github.com/metanorma/mn2pdf

And as far as I understood all needed fonts already available on windows. mn2pdf have internal logic for lookup fonts in the specific path on windows

As far as I understood we only need to download mn2pdf.jar in scope for chocolatey/homebrew/snap

Only one question from my side how ruby will call this jar, where this jar suppose to be?

@CAMOBAP CAMOBAP self-assigned this Apr 5, 2020
@ronaldtse
Copy link
Contributor

I believe @opoudjis is planning to embed mn2pdf inside the metanorma-standoc gem.

  1. Windows will need the Adobe Source Fonts (https://github.com/fontist/source-fonts), which fontist should install. These are installed separate from the gem because they are too large.

I noticed that you can use Chocolatey to install fonts, e.g.:

Maybe the easiest way to setup is to make a Chocolatey package for Adobe Source Fonts?

@ronaldtse
Copy link
Contributor

An essential component of this work is to identify the fonts directory on the current system to be used for PDF generation. The README in mn-native-pdf is mac only.

The metanorma specific fonts directory is ~/.metanorma/fonts. The GHA workflows on mn-native-pdf already works for Mac Linux Windows.

@CAMOBAP
Copy link
Contributor

CAMOBAP commented Apr 6, 2020

Maybe the easiest way to setup is to make a Chocolatey package for Adobe Source Fonts?

Probably make sens

As far as I understood both Source Code Pro Programming Font and Source Han Code JP are fonts from Adobe Source Fonts collection, @ronaldtse can you confirm this

If so, will https://github.com/fontist/fontist include all needed Adobe Source Fonts?

@CAMOBAP
Copy link
Contributor

CAMOBAP commented Apr 23, 2020

Waiting for fontist/fontist#5 to be able to install fonts with metanorma setup

CAMOBAP added a commit that referenced this issue May 5, 2020
CAMOBAP added a commit that referenced this issue May 5, 2020
CAMOBAP added a commit that referenced this issue May 15, 2020
@CAMOBAP
Copy link
Contributor

CAMOBAP commented May 15, 2020

Done

@CAMOBAP CAMOBAP closed this as completed May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants