Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nokogiri version needs bumping #297

Closed
ribose-jeffreylau opened this issue Jun 1, 2021 · 6 comments
Closed

Nokogiri version needs bumping #297

ribose-jeffreylau opened this issue Jun 1, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@ribose-jeffreylau
Copy link

ribose-jeffreylau commented Jun 1, 2021

See: GHSA-7rrm-v45f-jp64

It should also unblock metanorma/metanorma-ietf#150

Upgrading nokogiri to 1.11.0+ would require dropping support for Ruby 2.4, of which official support ended on 2020-04-05.

@ribose-jeffreylau ribose-jeffreylau added the enhancement New feature or request label Jun 1, 2021
@ribose-jeffreylau ribose-jeffreylau self-assigned this Jun 1, 2021
ribose-jeffreylau added a commit that referenced this issue Jun 1, 2021
ribose-jeffreylau added a commit that referenced this issue Jun 1, 2021
ribose-jeffreylau added a commit that referenced this issue Jun 1, 2021
@opoudjis
Copy link
Contributor

opoudjis commented Jun 1, 2021

@ribose-jeffreylau The upgrade to Nokogiri 1.11 is being blocked by https://github.com/metanorma/packed-mn , which requires Ruby 2.4 to function. Until such time as that dependency is resolved, no attempt to upgrade to Nokogiri 1.11 can be accepted.

@ronaldtse
Copy link
Contributor

The particular ticket where the Ruby upgrade is being worked on: metanorma/ruby-packer#9

@ronaldtse
Copy link
Contributor

@ribose-jeffreylau by any chance is this blocking your workflow?

@ribose-jeffreylau
Copy link
Author

@opoudjis Noted. Thanks!

@ronaldtse It's not blocking any workflow. It's just part of the process to resolve dependabot alerts.

@ronaldtse
Copy link
Contributor

Got it. Thanks @ribose-jeffreylau !

@ribose-jeffreylau
Copy link
Author

Closed by b3ca5bb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants