Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with 18-046 #21

Closed
ronaldtse opened this issue Feb 5, 2020 · 12 comments
Closed

Issues with 18-046 #21

ronaldtse opened this issue Feb 5, 2020 · 12 comments
Assignees
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link
Contributor

ronaldtse commented Feb 5, 2020

Issues to be handled in markup or metanorma-ogc:

  • In chapter 6 (Solutions), tag "elif" is used, but it isn't recognized by Metanorma when rendering. In order to check the output, I've changed this tag to "else" (this renders well), and then reverted change to "elif". Error output:
    C:/tools/ruby25/lib/ruby/gems/2.5.0/gems/liquid-4.0.3/lib/liquid/block.rb:38:in `unknown_tag': Liquid syntax error: Unkn
    own tag 'elseif' (Liquid::SyntaxError)
    Fixed in Metanorma fails to include content that contains Liquid-like syntax metanorma-standoc#200
  • Unnumbered tables are shown in the list of tables (I'm not sure if this is fine, since they are untitled).
  • Chapters order is different (for the first 3 chapters).
  • In .html version, xml codes go out of the margins, i.e. line breaks are not used instead.
  • [class=steps] is not working.
  • I've mainly used [source,xml] because there are no options available for many code types.
  • Warning on the front page has a different content, as well as the License Agreement.
  • There should be no "Open Geospatial Consortium OGC 18-046:2020" in the header, and the footer should be different.
@ronaldtse ronaldtse added the bug Something isn't working label Feb 5, 2020
@ronaldtse ronaldtse added this to To do in Editing via automation Feb 5, 2020
@ronaldtse ronaldtse added this to Needs triage in Nick Nicholas via automation Feb 5, 2020
@ronaldtse ronaldtse moved this from Needs triage to Urgent in Nick Nicholas Feb 5, 2020
@opoudjis
Copy link
Contributor

opoudjis commented Feb 5, 2020

First issue now resolved: metanorma/metanorma-standoc#200

@ronaldtse ronaldtse moved this from Urgent to High priority in Nick Nicholas Feb 11, 2020
@opoudjis opoudjis moved this from High priority to Urgent in Nick Nicholas Mar 2, 2020
opoudjis added a commit to metanorma/metanorma-ogc that referenced this issue Mar 3, 2020
@opoudjis
Copy link
Contributor

opoudjis commented Mar 3, 2020

In .html version, xml codes go out of the margins, i.e. line breaks are not used instead.

We have addressed this in metanorma/metanorma-ogc#86

Chapters order is different (for the first 3 chapters).

In OGC, stop recognising Introduction as part of the preface by default. (Already had to do so for foreword).

Unnumbered tables are shown in the list of tables (I'm not sure if this is fine, since they are untitled).

I can't replicate this: there are four tables, and all of them are numbered. The contacts list, which is unnumbered, is not in the list of tables; presumably I've already solved this issue.

@opoudjis
Copy link
Contributor

opoudjis commented Mar 3, 2020

Chapters order is different (for the first 3 chapters).

The order is now fixed, but the numbering of the Summary subsections is not i.1 but 1.1. We have not provided for subsections in prefatory sections. I'll note that http://docs.opengeospatial.org/per/18-046.html does not number the Summary as i but as 1.

i containing i.1 not 1.1 is an oversight, easily fixed.

opoudjis added a commit to metanorma/metanorma-ogc that referenced this issue Mar 3, 2020
@opoudjis
Copy link
Contributor

opoudjis commented Mar 3, 2020

[class=steps] is not working.

Metanorma defaults to alphabetic ordered lists. We have allowed Arabic numbering in ITU exceptionally, because they are used there for ordered steps; we have not generalised that solution to other flavours. We will impose uniform list numbering in the flavour unless explicitly given criteria to do otherwise; none have been provided for OGC. If OGC want consistent arabic rather than alphabetic ordered steps, we need to be instructed explicitly.

Noted as metanorma/metanorma-ogc#90. Confirmed in metanorma/metanorma-ogc#95

@opoudjis
Copy link
Contributor

opoudjis commented Mar 3, 2020

I've mainly used [source,xml] because there are no options available for many code types.

XML encompasses everything with angle brackets, it was the right choice.

Warning on the front page has a different content, as well as the License Agreement.

Warning discrepancy needs to be escalated to OGC: the warning adds the sentence "However, the discussions in this document could very well lead to the definition of an OGC Standard", which is not in our boilerplate.

The license boilerplate adds two paragraphs:

This Agreement is governed by the laws of the Commonwealth of Massachusetts. The application to this Agreement of the United Nations Convention on Contracts for the International Sale of Goods is hereby expressly excluded. In the event any provision of this Agreement shall be deemed unenforceable, void or invalid, such provision shall be modified so as to make it valid and enforceable, and as so modified the entire Agreement shall remain in full force and effect. No decision, action or inaction by LICENSOR shall be construed to be a waiver of any rights or remedies available to it.

None of the Intellectual Property or underlying information or technology may be downloaded or otherwise exported or reexported in violation of U.S. export laws and regulations. In addition, you are responsible for complying with any local laws in your jurisdiction which may impact your right to import, export or use the Intellectual Property, and you represent that you have complied with any regulations or registration procedures required by applicable law to make this license enforceable.

Reported to @ronaldtse to escalate.

Raised as metanorma/metanorma-ogc#91

@opoudjis
Copy link
Contributor

opoudjis commented Mar 3, 2020

Do not create contact box in HTML title page for doc types that don't include it.

opoudjis added a commit to metanorma/metanorma-ogc that referenced this issue Mar 3, 2020
@opoudjis
Copy link
Contributor

opoudjis commented Mar 3, 2020

There should be no "Open Geospatial Consortium OGC 18-046:2020" in the header, and the footer should be different.

@anermina What should they be instead, and why? The HTML and PDF of the document don't have any header and footer at all, and the Word header and footer are at least consistent.

@ronaldtse You may need to query OGC on what headers and footers they want to see.

@opoudjis
Copy link
Contributor

opoudjis commented Mar 3, 2020

Putting this issue on hold, pending resolution with OGC and Nermina.

@opoudjis opoudjis moved this from Urgent to On hold in Nick Nicholas Mar 3, 2020
@ronaldtse
Copy link
Contributor Author

@anermina @opoudjis the header/footer issue is now clarified in metanorma/metanorma-ogc#97.

@opoudjis
Copy link
Contributor

opoudjis commented Mar 4, 2020

@anermina
Copy link
Contributor

anermina commented Mar 4, 2020

Additionally, I've set the element [%unnumbered] before the source codes in #51 .

@opoudjis
Copy link
Contributor

The license boilerplate issue has been addressed. Therefore, this issue is closed.

Nick Nicholas automation moved this from On hold to Closed Mar 30, 2020
Editing automation moved this from To do to Done Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Editing
  
Done
Nick Nicholas
  
Closed
Development

No branches or pull requests

3 participants