-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows only | ffi-libarchive-binary/libarchive-13.dll': . (LoadError) #118
Comments
Originally found in https://github.com/metanorma/iso-10303-2/issues/49 Crash related to missing dll dependency (ffi-libarchive->ffi-libarchive-binary->libarchive->libexpat-1). The last one libexpat-1 comes from msys2 this is why it doesn't fail on CI and in my environment initially What I have done so far:
|
…y may note be preinstalled
libarchive is the module that creates pain :) There is similar problem solved here: https://github.com/mhx/dwarfs/blob/main/CMakeLists.txt . Look for keyword "pain" |
As far as I understood it depends on which flags were feeded to
Agree this is what we did in fontist/ffi-libarchive-binary#8
Yep, I have tried to put those missing DLLs in the same package where libarchive was, but "Windows doesn't like it" and still try to go own way to search places to load those DLLs ( BTW PR is green now so I hope we will not face this issue in future |
@maxirmx maybe you can share your opinion what are downsides of static link, I trying to decide should we do static link only for windows or for all our platforms.
Anything else we should consider? |
…y may note be preinstalled
Fix verified |
IMHO statically linked module is easier to maintain. No other thoughts |
The text was updated successfully, but these errors were encountered: