Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support <schema_diag> tag #41

Closed
ronaldtse opened this issue Feb 4, 2021 · 5 comments
Closed

Support <schema_diag> tag #41

ronaldtse opened this issue Feb 4, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@ronaldtse
Copy link
Contributor

We need to convert this also. From metanorma/iso-10303-stepmod#6 .

Missing rendering of <schema_diag> image:

Screen Shot 2021-02-04 at 12 40 23 PM
@ronaldtse
Copy link
Contributor Author

From iso-10303-stepmod I was only able to find this relevant snippet:

      <xsl:when test="contains(@file,'schema_diag')">
        
            <xsl:value-of 
              select="concat('Figure 1 ', 
                      ' &#8212; The relationship of schemas of this part to the standard ISO 10303 integration architecture')" />
      </xsl:when>
      <xsl:when test="contains(@file,'schemaexpg')">       
            <xsl:value-of 
              select="concat('Figure D. ', 
                      ' &#8212; Place calculated title here')" />
            </xsl:when>

I think we just treat it as a normal svgmap.

@ronaldtse ronaldtse added the enhancement New feature or request label Feb 4, 2021
w00lf added a commit that referenced this issue Feb 7, 2021
@ronaldtse
Copy link
Contributor Author

Implemented by @w00lf. Thanks!

@ronaldtse
Copy link
Contributor Author

@w00lf in the latest version we're still seeing this. Can you have a look?

Screenshot 2021-02-25 at 11 50 29 AM

@ronaldtse ronaldtse reopened this Feb 25, 2021
@w00lf
Copy link
Contributor

w00lf commented Feb 26, 2021

@w00lf in the latest version we're still seeing this. Can you have a look?

Screenshot 2021-02-25 at 11 50 29 AM

As it turns out this diagram was manually put into the adoc file.

@ronaldtse
Copy link
Contributor Author

Yes this is now fixed in the latest generated version (directly using image::, not svg)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants