-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test environment to run tests against local solana #93
Conversation
@olgkv Good job 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested a few changes via a call.
@olgkv have a look at amman, a package I just created to aid in setting up the validator and which will include convenience actions to be used for testing in the future. All you have to do is place a The config would be a combination of the below two (I spit it into base and inheritor since the mpl repo has multiple packages). Base
|
3d887b4
to
885c4b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some issues especially regarding the build setup depending on external tools.
Please fix and LMK when done so I can review again.
Also please DO address the points I'm raising before asking for another review, I feel like I'm commenting on some things (like the solana-validator.yml
in the .gitignore) a second time.
# mostly delete external tools, and replace them with nodejs packages
885c4b4
to
f76b375
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting closer, please fix the final points/nits I raised.
You resolved the issues I had, but I'm confused WRT to the github workflow .. it doesn't seem to complete .. ever?
The changes are fine, but I don't want yo to approve/merge this until we figure out why those checks aren't running properly. Nothing should get merged without passing checks and this PR adds a github workflow that runs integration tests as part of a workflow. So we need to see the existing ones passing before merging changes that add more. Does anyone know why they're stuck or why they don't get triggered? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I see the integration tests now actually are running 😄 .
There are still some issues that I pointed out.
Also could someone please figure out why the Pull Request workflow isn't running? We don't know for instance if the lint check passes and so on. It most likely also would have caught the missing TypeScript types etc.
6de1ec0
to
784b8ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with the understanding that the skipped test will be addressed.
🎉 This PR is included in version 4.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
local solana network
, using solana cli tool:solana-test-validator
local solana network