-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPC OAuth support and Candymachine only UI #944
Conversation
@jkbpvsc is attempting to deploy a commit to the Metaplex Team on Vercel. A member of the Team first needs to authorize it. |
@bhgames I was thinking of moving the oauth logic to the web3.js library, so authentication can be handled on the same level as the http client. |
lets get some movement on this so we can gfet it in |
We are working on integrating the oauth client into web3js, which will be used here. If you want to speed this up we can clean up this code as an intermediary solution and merge it. But ultimately the web3js oauth client will provide better ux and better control with oauth. |
@bhgames I've cleaned up the code:
|
Can I help unblock anything here? |
Let's just remove the candy machine stuff and just have the oauth. Because
we're about to revamp Candy machine anyway and that will require some
reconfiguration of the front end.
…On Fri, Dec 10, 2021 at 11:21 AM Jakob Povšič ***@***.***> wrote:
Can I help unblock anything here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#944 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACNA23OMZSPRXPPYWZMOSLUQIZJXANCNFSM5H2RLU2A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
*Jordan Prince* | Software Engineering
*O:* *301.751.7354* | *C:* *301.751.7354*
This e-mail is only intended for the person(s) to whom it is addressed and
may contain confidential information. Any unauthorized review, use,
disclosure, or distribution is prohibited. If you received this e-mail in
error, please notify the sender by reply e-mail and then delete this
message and any attachments from your system. Thank you for your
cooperation.
|
Opened a new PR #1193 |
This PR has a POC/Hackathon version of a PKCE OAuth client that can be used to authenticate requests to a Solana RPC nodes (https://github.com/rpcpool/rpc-oauth-client). The client logic is stripped out of the https://github.com/auth0/auth0-spa-js project.
Additionally, it has UI and logic for minting NFTs directly from a Candy machine program taken from the Exiled Ape project (https://github.com/exiled-apes/candy-machine-mint).
This UI is present only when a
REACT_APP_CANDY_MACHINE_ID
is provided andREACT_APP_FAIR_LAUNCH_ID
isn't.FD: This was hacked together in a few days, the oauth/authentication logic needs to be packaged nicely, so other projects can use it (ideally by being part of the https://github.com/solana-labs/solana-web3.js project).
And the Candymachine UI needs to be polished and better integrated into the fair launch codebase. This is an internim solution and should be replaced once the oauth client in web3js is supported