Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIP-9 #97

Merged
merged 6 commits into from
May 9, 2024
Merged

MIP-9 #97

merged 6 commits into from
May 9, 2024

Conversation

n00m4d
Copy link
Contributor

@n00m4d n00m4d commented May 7, 2024

What

This PR adds canopy size check to CreateTree instruction as described in MIP-9

Copy link
Contributor

@danenbm danenbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this so quickly! Changes look good, but left a couple comments. Also we will need to regenerate the clients, both the Umi js client and the js-solita one.

programs/bubblegum/program/src/error.rs Outdated Show resolved Hide resolved
programs/bubblegum/program/src/processor/create_tree.rs Outdated Show resolved Hide resolved
programs/bubblegum/program/tests/utils/context.rs Outdated Show resolved Hide resolved
Also set specific ahash version in Rust client:
cargo update -p ahash@0.8.11 --precise 0.8.6
@danenbm danenbm self-requested a review May 9, 2024 01:37
Copy link
Contributor

@danenbm danenbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danenbm
Copy link
Contributor

danenbm commented May 9, 2024

I fixed the CI issue by deleting the Cargo.lock file for the Rust client. This is a known issue that when we do cargo release, for some reason it downgrades the borsh version, causing a mismatch between borsh and kaigan packages.

Also I regenerated the solita JS SDK in case anyone is still using it. I was not able to get the Solita tests to run (they don't run in CI either). They still use yarn. I went into js-solita directory and did:

cd clients/js-solita
yarn install
yarn api:gen
git checkout ../../idls/bubblegum.json // note we don't want the Solita-generated IDL 
yarn build
yarn test

but the tests hang, maybe right at the beginning with the airdrop.

Unless you can figure out how to run the solita tests manually, I think since we are just adding the one error code to Solita SDK and the Solita SDK is in process of being deprecated, its probably fine to leave them.

@n00m4d n00m4d merged commit 7ca2d1c into main May 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants