Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor /process/start response #294

Closed
teosarca opened this issue Apr 11, 2017 · 3 comments
Closed

Refactor /process/start response #294

teosarca opened this issue Apr 11, 2017 · 3 comments

Comments

@teosarca
Copy link
Member

teosarca commented Apr 11, 2017

What is the current behavior?

The process execution result contains fields like:

  • reportFilename
  • reportContentType
  • openViewWindowId
  • openViewId
  • openDocumentWindowId
  • openDocumentId

which basically corresponds to following post process actions:

  • open report
  • open view
  • open single document window

What is the expected or desired behavior?

Have only one field, called "action", and based on which action it is, we shall have the required fields for that action. i.e.

  1. opening a report:
{
  type:"openReport",
  filename:"...",
  contentType: "..."
}

legacy fields are: reportFilename, reportContentType

  1. opening a view
{
  type:"openView",
  windowId: ... ,
  viewid: "..."
}

legacy fields are: openViewWindowId, openViewId

  1. open a single document:
{
  type:"openDocument",
  windowId:... ,
  documentId:
}

legacy fields are: openDocumentWindowId, openDocumentId


NOTE to IT: this is a pure technical task. So the only tests u could perform is regression on starting processes.

@damianprzygodzki
Copy link

error and summary stay as they were?

@teosarca
Copy link
Member Author

yes, they stay.

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Apr 13, 2017
[#631](metasfresh/metasfresh-webui-frontend-legacy#631) Minor grid view layout tweaks
[#628](https://github.com/metasfresh/metasfresh-webui-frontr /process/start response
[#294](metasfresh/metasfresh-webui-api-legacy#294) Refactor /process/start response
[#1291](#1291) Manufacturing Order Window adjustments
[#620](metasfresh/metasfresh-webui-frontend-legacy#620) When deleting a newly created document, frontend shall not ask the user if he/she wants to leave the page
[#619](metasfresh/metasfresh-webui-frontend-legacy#619) Address editor silently ignores changes if the mandatory fields are not filled
[#1057](#1057) Role window WebUI
[#267](metasfresh/metasfresh-webui-frontend-legacy#267) Sidelist refactor
[#886](#886) GrandTotal missing in GridView of Purchase Order
[#695](#695) swingUI: provide lib-dirs to access user jars and dlls at runtime
[#110](metasfresh/metasfresh-webui-frontend-legacy#110) Don't fetch the side list when it's not needed
[#88](metasfresh/metasfresh-webui-frontend-legacy#88) Special Place for Record dependent content
[#636](metasfresh/metasfresh-webui-frontend-legacy#636) Sidelist Fontsize too small

me-45
@metas-lc metas-lc self-assigned this Apr 20, 2017
@metas-lc
Copy link

IT
(task is OK, for the NOKs i found will create new tasks)

  • jasper process NOK
  1. select home button, write revenue, select Revenue Busines Partner
    => nothing happens NOK (jasper process)

  2. select browse the whole tree => process opens => nok too late (will create a frontend task)

  3. open the process from sitemap => opens fine OK

  4. in each case, add date to and date from , start
    => /rest/api/process/application/pdf/1348430/print/Umsatzreport+Geschäftspartner.pdf NOK (will create a backend task)
    => error: There was an unexpected error (type=Not Found, status=404).NOK

  5. go to business partner window, select an existing one and open the pricelist process from gear
    => data shall be filled but it's not NOK

  6. fill in the data , run the report
    => error: There was an unexpected error (type=Not Found, status=404). NOK

  • jasper documents OK
  1. go to sales or purchase order and select a completed order
  2. on actions select print
    => jasper docu opens fine
  • jasper labels OK
  1. go to material receipt candidates and select a line , open hu editor and run the label process
    => you can't see it because it's not configured but there are no errors
  • document creation processes OK
  1. go to sales order and create a new one
  2. add a product and complete it
  3. go to shipment candidate and from gear select the shipment creation process
  4. run the process
    => shipment was created OK
  5. go back to sales order and open the invoice candidates
  6. go to gear and select the process for invoice creation
    => invoices created OK
  7. go to purchase order and create a new one, add a product and complete it
  8. go to receipt candidates and select the one with the product
  9. use the green button to receive your HUs
  10. select create material receipt
    => new receipt was created OK
  11. go back to your purchase order and open the invoice candidates
  12. go to gear and select the process for invoice creation
    => invoices created OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants