Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Don't fetch the side list when it's not needed #110

Closed
teosarca opened this issue Nov 23, 2016 · 7 comments
Closed

Don't fetch the side list when it's not needed #110

teosarca opened this issue Nov 23, 2016 · 7 comments
Assignees
@damianprzygodzki
Labels
branch:master branch:release type:enhancement
Milestone
2017-16

Comments

@teosarca
Copy link
Member

Test case: open a particular sales order
=> the side list is fetched even though is not displayed and it might be never displayed

image
@damianprzygodzki
Copy link
Contributor

@teosarca We have to init here.This is because sideList is just regular gridView, that has to fetch for example layout at the init. Check also that is one and only call for sidelist - to avoid fetching so much data each time you open and close sidelist again.

This way of thinking is for dropdowns/lookups okay, whole views not okay.

@teosarca
Copy link
Member Author

@damianprzygodzki yes Damian, but why fetching it when user clicks first time on it.
I am saying this because in a lot of cases, when u navigate through documents, you as a user, you will not open the side list at all.

@teosarca teosarca reopened this Nov 28, 2016
@damianprzygodzki
Copy link
Contributor

damianprzygodzki commented Nov 28, 2016 •
edited
Loading

Okay, i see likely solution, but still, im not sure that is okay for views. Lazy loading is not always good from UX perspective. If we can do something in background, and forestall user behavior and let him do not wait for something, so lets do that. Seeing everywhere loaders giving for an user feeling of slow app.
@cadavre could you correct me? Should we put everywhere lazy loading?

@cadavre
Copy link
Contributor

cadavre commented Nov 28, 2016

We gonna probably change sidebar behaviour in some close future, as discussed with @metas-mk. We shall postpone this.

@teosarca
Copy link
Member Author

teosarca commented Dec 3, 2016

About lazy loading, i've created a new issue to gather ideas: #130

@damianprzygodzki
Copy link
Contributor

damianprzygodzki commented Mar 28, 2017 •
edited
Loading

I think we can close that issue and process it farther in #267 issue about sidelist rebuild. What do You think? @cadavre @teosarca

@damianprzygodzki damianprzygodzki mentioned this issue Mar 28, 2017
Closed
@damianprzygodzki damianprzygodzki self-assigned this Apr 11, 2017
@damianprzygodzki damianprzygodzki added this to the 2017-16 milestone Apr 11, 2017
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Apr 13, 2017
@metas-ts
Complement release notes
6bcc8cc 
[#631](metasfresh/metasfresh-webui-frontend-legacy#631) Minor grid view layout tweaks
[#628](https://github.com/metasfresh/metasfresh-webui-frontr /process/start response
[#294](metasfresh/metasfresh-webui-api-legacy#294) Refactor /process/start response
[#1291](#1291) Manufacturing Order Window adjustments
[#620](metasfresh/metasfresh-webui-frontend-legacy#620) When deleting a newly created document, frontend shall not ask the user if he/she wants to leave the page
[#619](metasfresh/metasfresh-webui-frontend-legacy#619) Address editor silently ignores changes if the mandatory fields are not filled
[#1057](#1057) Role window WebUI
[#267](metasfresh/metasfresh-webui-frontend-legacy#267) Sidelist refactor
[#886](#886) GrandTotal missing in GridView of Purchase Order
[#695](#695) swingUI: provide lib-dirs to access user jars and dlls at runtime
[#110](metasfresh/metasfresh-webui-frontend-legacy#110) Don't fetch the side list when it's not needed
[#88](metasfresh/metasfresh-webui-frontend-legacy#88) Special Place for Record dependent content
[#636](metasfresh/metasfresh-webui-frontend-legacy#636) Sidelist Fontsize too small

me-45
@metas-lc
Copy link

IT
sidelist not fetched anymore OK

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@damianprzygodzki damianprzygodzki

Labels
branch:master branch:release type:enhancement
Projects
None yet
Milestone
2017-16
Development

No branches or pull requests
5 participants
@cadavre @teosarca @metas-ts @damianprzygodzki @metas-lc