Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Sidelist refactor #267

Closed
damianprzygodzki opened this issue Feb 10, 2017 · 10 comments
Closed

Sidelist refactor #267

damianprzygodzki opened this issue Feb 10, 2017 · 10 comments

Comments

@damianprzygodzki
Copy link
Contributor

damianprzygodzki commented Feb 10, 2017

Pagination, sorting and filters should be cached.

After huge refactor of document list that was made in need by displaying HU in modals, way of working changed a lot. The sidelist now is the exeptional case of document list and it has to be rebuild too a bit.

The regular functionalities are kept but some of them will be fixed soon.

@damianprzygodzki damianprzygodzki changed the title Sidelist broken. Pagination, sorting and filters should be cached ... Sidelist pagination, sorting and filters should be cached ... Feb 10, 2017
@cadavre
Copy link
Contributor

cadavre commented Feb 13, 2017

Sidelist is scheduled for rebuilt. We can add "Pending" here.

@damianprzygodzki
Copy link
Contributor Author

As on #110, remember to fetch sidelist only when opened.

@cadavre
Copy link
Contributor

cadavre commented Mar 28, 2017

As I'm going to mock Manufacturing process, I'll try to prepare some initial ideas also for sidelist rebuild.

@damianprzygodzki damianprzygodzki changed the title Sidelist pagination, sorting and filters should be cached ... Sidelist refactor Mar 28, 2017
@damianprzygodzki
Copy link
Contributor Author

#88 and #98 looks influencing the new version of that (at least that area of window)

@metas-mk
Copy link
Member

@cadavre @cadavre thanks. looks nice.
Tested quickly. Please add keyboard control (arrow down, arrow up) for navigation in entries too.

image

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Apr 13, 2017
[#631](metasfresh/metasfresh-webui-frontend-legacy#631) Minor grid view layout tweaks
[#628](https://github.com/metasfresh/metasfresh-webui-frontr /process/start response
[#294](metasfresh/metasfresh-webui-api-legacy#294) Refactor /process/start response
[#1291](#1291) Manufacturing Order Window adjustments
[#620](metasfresh/metasfresh-webui-frontend-legacy#620) When deleting a newly created document, frontend shall not ask the user if he/she wants to leave the page
[#619](metasfresh/metasfresh-webui-frontend-legacy#619) Address editor silently ignores changes if the mandatory fields are not filled
[#1057](#1057) Role window WebUI
[#267](metasfresh/metasfresh-webui-frontend-legacy#267) Sidelist refactor
[#886](#886) GrandTotal missing in GridView of Purchase Order
[#695](#695) swingUI: provide lib-dirs to access user jars and dlls at runtime
[#110](metasfresh/metasfresh-webui-frontend-legacy#110) Don't fetch the side list when it's not needed
[#88](metasfresh/metasfresh-webui-frontend-legacy#88) Special Place for Record dependent content
[#636](metasfresh/metasfresh-webui-frontend-legacy#636) Sidelist Fontsize too small

me-45
@metas-lc
Copy link

IT
go to reference documents (ctrl+5) use up and down arrows => you can navigate OK
go to attachments (ctrl+6) use up and down arrows => you can navigate OK
go to document list (ctrl+4) use up and down arrows => you can't navigate NOK

@damianprzygodzki
Copy link
Contributor Author

damianprzygodzki commented Apr 21, 2017

@metas-lc it was discussed already with @metas-mk. The ctrl-4 gridview is regular gridview, in gridview we use tab instead of arrows. Nothing to fix from our side. Can we close that?

@teosarca
Copy link
Member

if it's a quickfix i would really like to be able to go to first row by pressing DOWN button.
It will be homogenous and will not require user to think about technical stuff like "ahh that's a regular gridview, i shall press tab instead of DOWN".
wdyt?

@metas-lc
Copy link

quickly checked. Tab is leaving the ctrl-4 menu bar. It selects document-actions

@metas-mk metas-mk self-assigned this Apr 24, 2017
@metas-mk
Copy link
Member

Checked latest status and test results.
Works as required. Remaining topic arrow down in sidelist grid view will be adressed later. Moving to done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants