Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Materialdispo Target Warehouse checks Warehouse Routing #633

Closed
metas-mk opened this issue Oct 13, 2017 · 3 comments
Closed

Materialdispo Target Warehouse checks Warehouse Routing #633

metas-mk opened this issue Oct 13, 2017 · 3 comments
Assignees
@metas-rc @metas-dh
Labels
branch:master branch:release type:bug

Comments

@metas-mk
Copy link
Member

Is this a bug or feature request?

Bug

What is the current behavior?

Currently, the Field Target Warehouse checks the results from Validation Rule additionally in Warehouse Routing.

Which are the steps to reproduce?

Open and see.

What is the expected or desired behavior?

Shall not check warehouse routing (this shall only happen for warehouse id).
metas-rc added a commit to metasfresh/metasfresh that referenced this issue Oct 23, 2017
@metas-rc
#633-webui Drop the validation rule from the Receipt Schedule's desti…
c7d9296 
…nation warehouse

metasfresh/metasfresh-webui-api-legacy#633
@metas-rc metas-rc mentioned this issue Oct 23, 2017
Merged
@metas-rc
Copy link
Member

metas-rc commented Oct 23, 2017 •
edited
Loading

Notes:

  • The warehouse logic is decided by the code, when the recepit schedule is created based on orderline. There is no validation rule in the database.
  • I dropped the validation rule for Warehouse_Dest. The side effect for this will be that in the swing versions the list of destination warehouses in the Wareneingang POS will be annoyingly long for big databases.

@teosarca
Copy link
Member

@metas-rc pls also check those 2 related tasks:

metas-rc added a commit to metasfresh/metasfresh that referenced this issue Oct 24, 2017
@metas-rc
#633-webui Unit Test
b1c941a 
metasfresh/metasfresh-webui-api-legacy#633
metas-rc added a commit to metasfresh/metasfresh that referenced this issue Oct 24, 2017
@metas-rc
#633-webui Propagate the tablename together with columnname when crea…
2771aa2 
…ting column lookups

metasfresh/metasfresh-webui-api-legacy#633
metas-rc added a commit to metasfresh/metasfresh that referenced this issue Oct 24, 2017
@metas-rc
#633-webui propagating tablename with columnname (continued)
b6a142a 
metasfresh/metasfresh-webui-api-legacy#633
metas-rc added a commit to metasfresh/metasfresh that referenced this issue Oct 24, 2017
@metas-rc
#633-webui refactoring
67e8e1f 
metasfresh/metasfresh-webui-api-legacy#633
metas-rc added a commit to metasfresh/metasfresh that referenced this issue Oct 24, 2017
@metas-rc
#633-webui register + getter for exceptions in the validation rule in…
e2d837b 
…terface

metasfresh/metasfresh-webui-api-legacy#633
metas-rc added a commit to metasfresh/metasfresh that referenced this issue Oct 24, 2017
@metas-rc
#633-webui register and get exception logic for validation rule imple…
263f9be 
…mentations

metasfresh/metasfresh-webui-api-legacy#633
metas-rc added a commit to metasfresh/metasfresh that referenced this issue Oct 24, 2017
@metas-rc
#633-webui implementation for tablename+columnname based validation r…
0816a5e 
…ules and for exceptions

metasfresh/metasfresh-webui-api-legacy#633
metas-rc added a commit to metasfresh/metasfresh that referenced this issue Oct 24, 2017
@metas-rc
#633-webui register exception for the M_ReceiptSchedule.M_Warehouse_D…
6255edd 
…est_ID

metasfresh/metasfresh-webui-api-legacy#633
metas-rc added a commit to metasfresh/metasfresh that referenced this issue Oct 24, 2017
@metas-rc
#633-webui fix a conflict with master
1469589 
metasfresh/metasfresh-webui-api-legacy#633
metas-rc added a commit that referenced this issue Oct 24, 2017
@metas-rc
#633-webui propagate the tablename too when dealing with column lookups
f2131af 
#633
metas-rc added a commit that referenced this issue Oct 24, 2017
@metas-rc
#633-webui propagate tablename in columnname lookup ( continued)
d626539 
#633
@metas-rc metas-rc mentioned this issue Oct 24, 2017
Merged
metas-rc added a commit that referenced this issue Oct 24, 2017
@metas-rc
#633-webui in webui column lookups the tablename shall be null
fa9e8ea 
* Repaired after Teo's review
#633
metas-rc added a commit that referenced this issue Oct 24, 2017
@metas-rc
#633-webui small cleanup
e09be98 
#633
metas-rc added a commit to metasfresh/metasfresh that referenced this issue Oct 24, 2017
@metas-rc
#633-webui do not propagate a context table name unless sure it's the…
615b548 
… one that is needed.

* I put null instead of the tablename
metasfresh/metasfresh-webui-api-legacy#633
metas-rc added a commit that referenced this issue Oct 24, 2017
@metas-rc
#633-webui bug-repair
1747d05 
#633
metas-rc added a commit to metasfresh/metasfresh that referenced this issue Oct 24, 2017
@metas-rc
#633-webui bug-repair
5983b01 
metasfresh/metasfresh-webui-api-legacy#633
metas-rc added a commit to metasfresh/metasfresh that referenced this issue Oct 25, 2017
@metas-rc
#633-webui I don't want to keep these hardcoded. I am not sure the ta…
53b8a8c 
…blename will always be the same

metasfresh/metasfresh-webui-api-legacy#633
metas-rc added a commit to metasfresh/metasfresh that referenced this issue Oct 25, 2017
@metas-rc
#633 Replace NotImplementedException with UnsupportedOperationException
9677fd7 
metasfresh/metasfresh-webui-api-legacy#633
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Nov 5, 2017
@metas-ts
Update ReleaseNotes.md [WIP]
b4208ff 
[#2881](#2881) Add a
process that removes pauses and can be ran from Contract window
[#633](metasfresh/metasfresh-webui-api-legacy#633)
Materialdispo Target Warehouse checks Warehouse Routing
[#2895](#2895)
AD_Ref_Table needs lower-case WHERE and FROM
[#2273](#2273) Payment
Selection as real Document
[#2862](#2862) Set
MasterStartDate for a contract when creating from order
[#2880](#2880) Add
greeting to partner quick creation from order
[#656](metasfresh/metasfresh-webui-api-legacy#656)
Address editor fields are not translated
[#654](metasfresh/metasfresh-webui-api-legacy#654)
Address country lookup not working correctly
[#1295](metasfresh/metasfresh-webui-frontend-legacy#1295)
processes: provide current selected tab and rows
[#1295](metasfresh/metasfresh-webui-api-legacy#653)
metasfresh.webui.debug.showColumnNamesForCaption shall be false by
default
[#651](metasfresh/metasfresh-webui-api-legacy#651)
Document references endpoints are not respecting role permissions
[#2878](#2878) Support
for 6 digits AccountNo length in ReferenceNumber
[#1312](metasfresh/metasfresh-webui-frontend-legacy#1312)
Wrong process call
[#2876](#2876) Fix
Recreate printing queue for webui
[#2874](#2874) Create
special filters in printing queue
[metasfresh-dist-orgs#82](metasfresh/metasfresh-dist-orgs#82)
Invoice Medium Address Layout Changes
[#2866](#2866) Make sure
that 'Print All' is working in webui
[#2803](#2803) Set
hostkey for printing module when login in webui
[#2113](#2113) Move
verify BOM process to BOM window

me-45
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Nov 5, 2017
@metas-ts
Update ReleaseNotes.md [WIP]
693cba4 
[#2881](#2881) Add a
process that removes pauses and can be ran from Contract window
[#633](metasfresh/metasfresh-webui-api-legacy#633)
Materialdispo Target Warehouse checks Warehouse Routing
[#2895](#2895)
AD_Ref_Table needs lower-case WHERE and FROM
[#2273](#2273) Payment
Selection as real Document
[#2862](#2862) Set
MasterStartDate for a contract when creating from order
[#2880](#2880) Add
greeting to partner quick creation from order
[#656](metasfresh/metasfresh-webui-api-legacy#656)
Address editor fields are not translated
[#654](metasfresh/metasfresh-webui-api-legacy#654)
Address country lookup not working correctly
[#1295](metasfresh/metasfresh-webui-frontend-legacy#1295)
processes: provide current selected tab and rows
[#1295](metasfresh/metasfresh-webui-api-legacy#653)
metasfresh.webui.debug.showColumnNamesForCaption shall be false by
default
[#651](metasfresh/metasfresh-webui-api-legacy#651)
Document references endpoints are not respecting role permissions
[#2878](#2878) Support
for 6 digits AccountNo length in ReferenceNumber
[#1312](metasfresh/metasfresh-webui-frontend-legacy#1312)
Wrong process call
[#2876](#2876) Fix
Recreate printing queue for webui
[#2874](#2874) Create
special filters in printing queue
[metasfresh-dist-orgs#82](metasfresh/metasfresh-dist-orgs#82)
Invoice Medium Address Layout Changes
[#2866](#2866) Make sure
that 'Print All' is working in webui
[#2803](#2803) Set
hostkey for printing module when login in webui
[#2113](#2113) Move
verify BOM process to BOM window

me-45

(cherry picked from commit b4208ff)
@metas-rc metas-rc mentioned this issue Nov 8, 2017
Closed
@metas-rc metas-rc mentioned this issue Nov 8, 2017
Closed
@metas-dh metas-dh self-assigned this Nov 14, 2017
@metas-dh
Copy link
Member

Results of IT1
tested in mf15

target warehouse in material receipt schedule:

  • all warehouses in dropdown shown which are possible target warehouses in a distribution network (for Wareneingang): OK
  • if warehouse has doc type Material Receipt, but is no target warehouse in a distribution network, then it is not selectable as target warehouse in material receipt schedule: OK
  • warehouse in material receipt schedule: all warehouses selectable that have doc type Material Receipt, or no doctype at all: OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metas-rc metas-rc

@metas-dh metas-dh

Labels
branch:master branch:release type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@teosarca @metas-ts @metas-mk @metas-rc @metas-dh