Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Wrong process call #1312

Closed
teosarca opened this issue Oct 31, 2017 · 2 comments
Closed

Wrong process call #1312

teosarca opened this issue Oct 31, 2017 · 2 comments
Labels
branch:master branch:release priority:high type:bug

Comments

@teosarca
Copy link
Member

Is this a bug or feature request?

Bug

Which are the steps to reproduce?

  • open a bpartner, e.g. https://w101.metasfresh.com:8443/window/123/2156425
  • from document references jump to handling units window (btw, u can reproduce it by jumping to any other window)
  • in handling units window, just select a row and call first action (does not matter which one, just call one)
    image
    image
    image

What is the expected or desired behavior?

Don't provide the selectedTab because there is no selectedTab here. I think that one somehow remained in memory from previous window?!?

More, there is no point to provide selectedTab if not providing windowId and documentId.
teosarca added a commit to metasfresh/metasfresh-webui-api-legacy that referenced this issue Oct 31, 2017
@teosarca
avoid the error on backend side
23a7351 
metasfresh/metasfresh-webui-frontend-legacy#1312
pablosichert added a commit that referenced this issue Nov 1, 2017
@pablosichert
Unset active tab when unmounting <Tabs>
44af7c0 
Issue #1312
@pablosichert pablosichert mentioned this issue Nov 1, 2017
Merged
@teosarca
Copy link
Member Author

teosarca commented Nov 1, 2017

note to IT:
Now we are also avoiding this issue on backend side. So pls just make sure the frontend is not sending the "selectedTab" without sending the "windowId" and "documentId".

@metas-lc
Copy link

metas-lc commented Nov 1, 2017

IT

  1. repeated the testcase above => works fine: there is only "viewDocumentIds"
  2. tested another case: order -> shipment disposition -> create shipment => ok, no errors, there is only "viewDocumentIds"

@metas-lc metas-lc closed this as completed Nov 1, 2017
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Nov 5, 2017
@metas-ts
Update ReleaseNotes.md [WIP]
b4208ff 
[#2881](#2881) Add a
process that removes pauses and can be ran from Contract window
[#633](metasfresh/metasfresh-webui-api-legacy#633)
Materialdispo Target Warehouse checks Warehouse Routing
[#2895](#2895)
AD_Ref_Table needs lower-case WHERE and FROM
[#2273](#2273) Payment
Selection as real Document
[#2862](#2862) Set
MasterStartDate for a contract when creating from order
[#2880](#2880) Add
greeting to partner quick creation from order
[#656](metasfresh/metasfresh-webui-api-legacy#656)
Address editor fields are not translated
[#654](metasfresh/metasfresh-webui-api-legacy#654)
Address country lookup not working correctly
[#1295](metasfresh/metasfresh-webui-frontend-legacy#1295)
processes: provide current selected tab and rows
[#1295](metasfresh/metasfresh-webui-api-legacy#653)
metasfresh.webui.debug.showColumnNamesForCaption shall be false by
default
[#651](metasfresh/metasfresh-webui-api-legacy#651)
Document references endpoints are not respecting role permissions
[#2878](#2878) Support
for 6 digits AccountNo length in ReferenceNumber
[#1312](metasfresh/metasfresh-webui-frontend-legacy#1312)
Wrong process call
[#2876](#2876) Fix
Recreate printing queue for webui
[#2874](#2874) Create
special filters in printing queue
[metasfresh-dist-orgs#82](metasfresh/metasfresh-dist-orgs#82)
Invoice Medium Address Layout Changes
[#2866](#2866) Make sure
that 'Print All' is working in webui
[#2803](#2803) Set
hostkey for printing module when login in webui
[#2113](#2113) Move
verify BOM process to BOM window

me-45
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Nov 5, 2017
@metas-ts
Update ReleaseNotes.md [WIP]
693cba4 
[#2881](#2881) Add a
process that removes pauses and can be ran from Contract window
[#633](metasfresh/metasfresh-webui-api-legacy#633)
Materialdispo Target Warehouse checks Warehouse Routing
[#2895](#2895)
AD_Ref_Table needs lower-case WHERE and FROM
[#2273](#2273) Payment
Selection as real Document
[#2862](#2862) Set
MasterStartDate for a contract when creating from order
[#2880](#2880) Add
greeting to partner quick creation from order
[#656](metasfresh/metasfresh-webui-api-legacy#656)
Address editor fields are not translated
[#654](metasfresh/metasfresh-webui-api-legacy#654)
Address country lookup not working correctly
[#1295](metasfresh/metasfresh-webui-frontend-legacy#1295)
processes: provide current selected tab and rows
[#1295](metasfresh/metasfresh-webui-api-legacy#653)
metasfresh.webui.debug.showColumnNamesForCaption shall be false by
default
[#651](metasfresh/metasfresh-webui-api-legacy#651)
Document references endpoints are not respecting role permissions
[#2878](#2878) Support
for 6 digits AccountNo length in ReferenceNumber
[#1312](metasfresh/metasfresh-webui-frontend-legacy#1312)
Wrong process call
[#2876](#2876) Fix
Recreate printing queue for webui
[#2874](#2874) Create
special filters in printing queue
[metasfresh-dist-orgs#82](metasfresh/metasfresh-dist-orgs#82)
Invoice Medium Address Layout Changes
[#2866](#2866) Make sure
that 'Print All' is working in webui
[#2803](#2803) Set
hostkey for printing module when login in webui
[#2113](#2113) Move
verify BOM process to BOM window

me-45

(cherry picked from commit b4208ff)
ottosichert pushed a commit that referenced this issue Nov 5, 2017
@pablosichert @ottosichert
Unset active tab when unmounting <Tabs>
9ec8afb 
Issue #1312
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
branch:master branch:release priority:high type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@teosarca @metas-ts @pablosichert @metas-lc