Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling Unit Editor Action Internal Usage not possible for more than 1 Page #668

Closed
metas-mk opened this issue Nov 9, 2017 · 6 comments
Closed

Handling Unit Editor Action Internal Usage not possible for more than 1 Page #668

metas-mk opened this issue Nov 9, 2017 · 6 comments
Assignees
@teosarca @metas-dh
Labels
branch:master branch:release priority:high type:enhancement

Comments

@metas-mk
Copy link
Member

metas-mk commented Nov 9, 2017

Is this a bug or feature request?

Feature Request

What is the current behavior?

Currently, the user cannot "select All" and use Internal Usage Action. Only select all on Page works.

Which are the steps to reproduce?

Check and see.

What is the expected or desired behavior?

Shall also work for "Select All" in HU Editor https://w101.metasfresh.com:8443/window/540189
teosarca added a commit that referenced this issue Nov 10, 2017
@teosarca
extract HUEditorRowFilter to it's own file
75f9c51 
#668
teosarca added a commit to metasfresh/metasfresh that referenced this issue Nov 11, 2017
@teosarca
de.metas.util: pom.xml: add assertj
d860fe1 
metasfresh/metasfresh-webui-api-legacy#668
teosarca added a commit to metasfresh/metasfresh that referenced this issue Nov 11, 2017
@teosarca
code format
652ad75 
metasfresh/metasfresh-webui-api-legacy#668
teosarca added a commit to metasfresh/metasfresh that referenced this issue Nov 11, 2017
@teosarca
IteratorUtils.stream(iterator) shall use Spliterator.ORDERED
c2bf3d5 
metasfresh/metasfresh-webui-api-legacy#668
teosarca added a commit to metasfresh/metasfresh that referenced this issue Nov 11, 2017
@teosarca
BlindIterator: stream() and iterator() default methods
7cc45cc 
metasfresh/metasfresh-webui-api-legacy#668
teosarca added a commit to metasfresh/metasfresh that referenced this issue Nov 11, 2017
@teosarca
PagedIterator
ab56a9d 
metasfresh/metasfresh-webui-api-legacy#668
teosarca added a commit to metasfresh/metasfresh that referenced this issue Nov 11, 2017
@teosarca
PagedIterator
fdec8bf 
metasfresh/metasfresh-webui-api-legacy#668
teosarca added a commit to metasfresh/metasfresh that referenced this issue Nov 11, 2017
@teosarca
StreamUtils.bufferAndMap
ab64a59 
metasfresh/metasfresh-webui-api-legacy#668
teosarca added a commit to metasfresh/metasfresh that referenced this issue Nov 11, 2017
@teosarca
StreamUtils.dice
ee0b9ba 
... and drop "bufferAndMap" method because it's redundant and harder to
use.

metasfresh/metasfresh-webui-api-legacy#668
teosarca added a commit to metasfresh/metasfresh that referenced this issue Nov 11, 2017
@teosarca
PagedIterator: refactoring
089c944 
metasfresh/metasfresh-webui-api-legacy#668
teosarca added a commit to metasfresh/metasfresh that referenced this issue Nov 11, 2017
@teosarca
drop PagedIterator.DEFAULT_PAGESIZE; we shall not guess it
2085789 
metasfresh/metasfresh-webui-api-legacy#668
teosarca added a commit that referenced this issue Nov 11, 2017
@teosarca
HUMoveToDirectWarehouseService.setFailIfNoHUs
6608de9 
#668
teosarca added a commit that referenced this issue Nov 11, 2017
@teosarca
HUEditorViewBuffer_HighVolume: support for streaming DocumentIdsSelec…
d1b5f53 
…tion.ALL

also: changed all methods which are returning rows lists to streaming.
we have to do this because it might be that we will handle very large
amount of data.

#668
teosarca added a commit that referenced this issue Nov 11, 2017
@teosarca
minor
c38705f 
#668
teosarca added a commit that referenced this issue Nov 11, 2017
@teosarca
bugfix typo
ab89954 
#668
teosarca added a commit that referenced this issue Nov 11, 2017
@teosarca
masive refactoring
98bc509 
#668
teosarca added a commit that referenced this issue Nov 12, 2017
@teosarca
drop toBuilder(); not used
d9e7a32 
#668
teosarca added a commit that referenced this issue Nov 12, 2017
@teosarca
merge HUEditorRowQuery to HUEditorRowFilter; refactor
70fb3b0 
#668
teosarca added a commit to metasfresh/metasfresh that referenced this issue Nov 12, 2017
@teosarca
IHUQueryBuilder.addHUStatusesToExclude(collection)
61c5b08 
metasfresh/metasfresh-webui-api-legacy#668
teosarca added a commit to metasfresh/metasfresh that referenced this issue Nov 12, 2017
@teosarca
PagedIterator: introduce Page with lastRow as response
af4c198 
metasfresh/metasfresh-webui-api-legacy#668
teosarca added a commit that referenced this issue Nov 12, 2017
@teosarca
use PagedIterator.Page
eb6070e 
#668
teosarca added a commit that referenced this issue Nov 12, 2017
@teosarca
refactor and introduce SqlViewSelect
9c088cc 
#668
teosarca added a commit to metasfresh/metasfresh that referenced this issue Nov 12, 2017
@teosarca
PagedIterator.Page minor improvements
ecacf8a 
metasfresh/metasfresh-webui-api-legacy#668
teosarca added a commit that referenced this issue Nov 12, 2017
@teosarca
SqlHUEditorViewRepository: retrieve lastRow
4a9d41d 
#668
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Nov 12, 2017
@metas-ts
Update ReleaseNote.md
e76185e 
[#668](metasfresh/metasfresh-webui-api-legacy#668)
Handling Unit Editor Action Internal Usage not possible for more than 1
Page
[#664](metasfresh/metasfresh-webui-api-legacy#664)
Create Purchase Order Line by Line via Sales Order Lines
[#1327](metasfresh/metasfresh-webui-frontend-legacy#1327)
frontend: Change the JSONLookupValue format
[#1199](metasfresh/metasfresh-webui-frontend-legacy#1199)
Picking Window unselect line in modal overlay
[#666](metasfresh/metasfresh-webui-api-legacy#666)
Change the JSONLookupValue format
[#1308](metasfresh/metasfresh-webui-frontend-legacy#1308)
Closing a document with changes shall discard those changes
[#1286](metasfresh/metasfresh-webui-frontend-legacy#1286)
Error when maximize subtab which does not support quick input
[#1279](metasfresh/metasfresh-webui-frontend-legacy#1279)
menu actions for included row broken
[#2917](#2917) Allow
reactivating procurement contracts
[#2754](#2754) Cleanup
Function for old AD_Issue records
[#2816](#2816) Material
Dispo - include storage-relevant attributes
[#649](metasfresh/metasfresh-webui-api-legacy#649)
Qty Delivered and Qty Picked not updated correctly in shipment schedule
[#1219](metasfresh/metasfresh-webui-frontend-legacy#1219)
Show mandatory fields not in blue but in red to match user expectation
[#2914](#2914) Replace
org.adempiere.util.collections.Predicate with
java.util.function.Predicate
[#660](metasfresh/metasfresh-webui-api-legacy#660)
JSONUserSessionChangesEvent not fired when currently logged in user is
changed

me-45
@metas-dh metas-dh self-assigned this Nov 13, 2017
teosarca added a commit that referenced this issue Nov 13, 2017
@teosarca
rename SqlViewSelect to SqlViewSelectData
010ae52 
#668
@teosarca teosarca mentioned this issue Nov 13, 2017
Merged
@teosarca
Copy link
Member

note to IT: besides testing the task, FULL REGRESSION is needed.
Check some standard views (order etc), check picking terminal, manufacturing issue/receipt, HU editor etc.

@teosarca teosarca reopened this Nov 13, 2017
@metas-dh
Copy link
Member

metas-dh commented Nov 16, 2017 •
edited by metas-ts
Loading

Results of IT1
tested on large DB (more HUs in Editor to test with)

  1. Open Handling Unit Editor, filter for active HUs in a certain warehouse: 11 pages
  2. Select all with [ctrl]+a: all HUs in the current page are selected, OK
  3. Check next page: nothing selected: NOK i think, afaiu all HUs shall be selected in all pages?
  4. Select all HUs in the current page with [ctrl]+a, select Internal Usage (Materialentnahme) in Action menu: all selected HUs from the page disappear, OK
    (5. Check notification: no notification about the movement created for the Materialentnahme; didn't we usually get a notification about that? Movements were created correctly, though))
  5. Check next page: all HUs still there, NOK
  6. Go back to page 1: Empty, "Es sind noch keine Detailzeilen vorhanden", but 10 more pages exist; you have to run the filter again to get HUs displayed on the 1st page

@teosarca teosarca self-assigned this Nov 16, 2017
@metas-dh
Copy link
Member

metas-dh commented Nov 16, 2017 •
edited
Loading

update:
checked with metas-mk: to select all HUs in all pages, use 2x [ctrl]+a
=> 2x [ctrl]+a, and Internal Usage (Materialentnahme): all HUs are moved, and not displayed anymore in Handling Unit Editor: OK

no HUs selected when turning the page: metasfresh/metasfresh-webui-frontend-legacy#1348

@metas-dh
Copy link
Member

Regression testing:

  • manufacturing: issue / receipt working fine (partial issue, reverse, pick etc.)
  • picking: picking working fine (pick, reverse, source HU etc.)

question:
using [ctrl]+a in a HU Editor with 2 sides, e.g. manufacturing: when i use [ctrl]+a in HU Editor on the right side bc i want to select all available HUs for issueing, than all lines in both sides are selected, and the Action menu is not available anymore, so i can't issue; is that OK?

2017-11-16 16_15_29-

same in picking: i can only use select all from this side, not [ctrl]+a to select all available HUs for picking

@teosarca
Copy link
Member

@metas-dh now i cannot reproduce... might be because shortcuts where recently changed.
Also, as it sounds like it seems to be a frontend issue if i understand it correctly.

@metas-mk wdyt?

@metas-dh
Copy link
Member

created metasfresh/metasfresh-webui-frontend-legacy#1515, closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teosarca teosarca

@metas-dh metas-dh

Labels
branch:master branch:release priority:high type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@teosarca @metas-ts @metas-mk @metas-dh