Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

frontend: Change the JSONLookupValue format #1327

Closed
teosarca opened this issue Nov 8, 2017 · 4 comments
Closed

frontend: Change the JSONLookupValue format #1327

teosarca opened this issue Nov 8, 2017 · 4 comments
Assignees
@metas-dh
Labels
branch:master branch:release priority:high type:enhancement

Comments

@teosarca
Copy link
Member

teosarca commented Nov 8, 2017

See metasfresh/metasfresh-webui-api-legacy#666
pablosichert added a commit that referenced this issue Nov 8, 2017
@pablosichert
Refactor inline logic for readability
40386fe 
Issue #1327
pablosichert added a commit that referenced this issue Nov 8, 2017
@pablosichert
Adapt <Labels> to new dropdown API
222bfaa 
Issue #1327
pablosichert added a commit that referenced this issue Nov 8, 2017
@pablosichert
Adapt <ActionButton> to new dropdown API
dbe6b00 
Issue #1327
pablosichert added a commit that referenced this issue Nov 8, 2017
@pablosichert
Adapt <List> to new dropdown API
ffde649 
Issue #1327
pablosichert added a commit that referenced this issue Nov 8, 2017
@pablosichert
Add compatibility layer to patch request which uses the new API forma…
5958475 
…t only

Issue #1327
pablosichert added a commit that referenced this issue Nov 8, 2017
@pablosichert
Fix caption in <TableCell>
d0ab9b4 
Issue #1327
pablosichert added a commit that referenced this issue Nov 8, 2017
@pablosichert
Downgrade payload[0].value.values requests
407b17b 
Issue #1327
@pablosichert pablosichert mentioned this issue Nov 8, 2017
Merged
@teosarca
Copy link
Member Author

teosarca commented Nov 9, 2017

After integrating the PR, this is the only issue (so far) which i found:
image

@teosarca
Copy link
Member Author

teosarca commented Nov 9, 2017

another issue: lookup widgets are not displaying the correct caption.
IMPORTANT: you shall transmit back the object EXACTLY as you get it because in some cases, the typeahead/dropdown will provide items which have more than key and caption attributes.... and backend expects them back.

image

pablosichert added a commit that referenced this issue Nov 9, 2017
@pablosichert
Remove no longer needed compatibility layer
f61f732 
Issue #1327
pablosichert added a commit that referenced this issue Nov 9, 2017
@pablosichert
Adapt <ActionButton> to new dropdown API
d1aa5e4 
Issue #1327
pablosichert added a commit that referenced this issue Nov 9, 2017
@pablosichert
Adapt <LookupList> and <RawLookup> to new dropdown API
b434413 
Issue #1327
pablosichert added a commit that referenced this issue Nov 9, 2017
@pablosichert
Partially adapt <Attributes> to new dropdown API
68e81f1 
Issue #1327
@pablosichert pablosichert mentioned this issue Nov 9, 2017
Merged
@metas-mk
Copy link
Member

metas-mk commented Nov 9, 2017 •
edited by teosarca
Loading

Error: Open Handling Unit Editor. https://w101.metasfresh.com:8443/window/540189
Press Filter>>Standard/ Default. Select dropdown for "Gebinde Status/ HU Status". Error see Image.
image

update (teosarca): fixed by c8079a6

@teosarca teosarca reopened this Nov 9, 2017
teosarca added a commit that referenced this issue Nov 9, 2017
@teosarca
avoid NPE
c8079a6 
#1327 (comment)
metas-ts pushed a commit that referenced this issue Nov 10, 2017
@pablosichert @metas-ts
Refactor inline logic for readability
f9a0526 
Issue #1327

(cherry picked from commit 40386fe)
metas-ts pushed a commit that referenced this issue Nov 10, 2017
@pablosichert @metas-ts
Adapt <Labels> to new dropdown API
b080e1c 
Issue #1327

(cherry picked from commit 222bfaa)
metas-ts pushed a commit that referenced this issue Nov 10, 2017
@pablosichert @metas-ts
Adapt <ActionButton> to new dropdown API
31997b0 
Issue #1327

(cherry picked from commit dbe6b00)
metas-ts pushed a commit that referenced this issue Nov 10, 2017
@pablosichert @metas-ts
Adapt <List> to new dropdown API
e631a62 
Issue #1327

(cherry picked from commit ffde649)
metas-ts pushed a commit that referenced this issue Nov 10, 2017
@pablosichert @metas-ts
Add compatibility layer to patch request which uses the new API forma…
0d3ee9d 
…t only

Issue #1327

(cherry picked from commit 5958475)
metas-ts pushed a commit that referenced this issue Nov 10, 2017
@pablosichert @metas-ts
Fix caption in <TableCell>
1d60c17 
Issue #1327

(cherry picked from commit d0ab9b4)
metas-ts pushed a commit that referenced this issue Nov 10, 2017
@pablosichert @metas-ts
Downgrade payload[0].value.values requests
58a2130 
Issue #1327

(cherry picked from commit 407b17b)
metas-ts pushed a commit that referenced this issue Nov 10, 2017
@pablosichert @metas-ts
Remove no longer needed compatibility layer
573bf0c 
Issue #1327

(cherry picked from commit f61f732)
metas-ts pushed a commit that referenced this issue Nov 10, 2017
@pablosichert @metas-ts
Adapt <ActionButton> to new dropdown API
7e3f96f 
Issue #1327

(cherry picked from commit d1aa5e4)
metas-ts pushed a commit that referenced this issue Nov 10, 2017
@pablosichert @metas-ts
Adapt <LookupList> and <RawLookup> to new dropdown API
8d86e5b 
Issue #1327

(cherry picked from commit b434413)
metas-ts pushed a commit that referenced this issue Nov 10, 2017
@pablosichert @metas-ts
Partially adapt <Attributes> to new dropdown API
1d99be1 
Issue #1327

(cherry picked from commit 68e81f1)
metas-ts pushed a commit that referenced this issue Nov 10, 2017
@teosarca @metas-ts
avoid NPE
cd66488 
#1327 (comment)
(cherry picked from commit c8079a6)
teosarca added a commit that referenced this issue Nov 10, 2017
@teosarca
hotfixed quick BPartner record creation
4872314 
#1327
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Nov 12, 2017
@metas-ts
Update ReleaseNote.md
e76185e 
[#668](metasfresh/metasfresh-webui-api-legacy#668)
Handling Unit Editor Action Internal Usage not possible for more than 1
Page
[#664](metasfresh/metasfresh-webui-api-legacy#664)
Create Purchase Order Line by Line via Sales Order Lines
[#1327](metasfresh/metasfresh-webui-frontend-legacy#1327)
frontend: Change the JSONLookupValue format
[#1199](metasfresh/metasfresh-webui-frontend-legacy#1199)
Picking Window unselect line in modal overlay
[#666](metasfresh/metasfresh-webui-api-legacy#666)
Change the JSONLookupValue format
[#1308](metasfresh/metasfresh-webui-frontend-legacy#1308)
Closing a document with changes shall discard those changes
[#1286](metasfresh/metasfresh-webui-frontend-legacy#1286)
Error when maximize subtab which does not support quick input
[#1279](metasfresh/metasfresh-webui-frontend-legacy#1279)
menu actions for included row broken
[#2917](#2917) Allow
reactivating procurement contracts
[#2754](#2754) Cleanup
Function for old AD_Issue records
[#2816](#2816) Material
Dispo - include storage-relevant attributes
[#649](metasfresh/metasfresh-webui-api-legacy#649)
Qty Delivered and Qty Picked not updated correctly in shipment schedule
[#1219](metasfresh/metasfresh-webui-frontend-legacy#1219)
Show mandatory fields not in blue but in red to match user expectation
[#2914](#2914) Replace
org.adempiere.util.collections.Predicate with
java.util.function.Predicate
[#660](metasfresh/metasfresh-webui-api-legacy#660)
JSONUserSessionChangesEvent not fired when currently logged in user is
changed

me-45
@metas-dh
Copy link
Member

Results of IT1
tested in mf15

checked all the reported lookup problems:

  • docstatus: OK
  • dropdown product name: OK
  • dropdown Gebinde Status in HU Editor filter: OK, no error
  • language change user: OK
  • PP_Order status: OK
  • drropdowns in contract term: OK
  • ceation of new bpartner in order: OK

@metas-dh metas-dh mentioned this issue Nov 14, 2017
Closed
@teosarca teosarca mentioned this issue Nov 17, 2017
Closed
This was referenced Nov 21, 2017
Closed
Merged
@teosarca teosarca mentioned this issue Jan 25, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@metas-dh metas-dh

Labels
branch:master branch:release priority:high type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@teosarca @metas-ts @pablosichert @metas-mk @metas-dh