Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception when opening PP Order issue / receipt #528

Closed
metasnw opened this issue Aug 1, 2017 · 3 comments
Closed

Exception when opening PP Order issue / receipt #528

metasnw opened this issue Aug 1, 2017 · 3 comments
Labels
branch:master branch:release type:bug

Comments

@metasnw
Copy link
Member

metasnw commented Aug 1, 2017

Is this a bug or feature request?

bug

What is the current behavior?

metasfresh/metasfresh-webui-frontend-legacy#1108

Which are the steps to reproduce?

metasfresh/metasfresh-webui-frontend-legacy#1108

What is the expected or desired behavior?

no exception
@metas-ts
Copy link
Member

metas-ts commented Aug 2, 2017

Intermediate results
i found the log and the M_HU the error is about.

the hu in question has an invalid m_hu_item record, because that record has

  • ItemType='HA'
  • M_HU_PI_Item_ID is null

I searched forward and found that the HU was created by the process WEBUI_PP_Order_Receipt with the following parameters:

select * from ad_pinstance_para where ad_pinstance_id=1520068;
 ad_pinstance_id | seqno |      parametername      |                p_string                 | p_string_to | p_number | p_number_to | p_date | p_date_to |          info          | info_to | ad_client_id | ad_org_id |        created         | createdby |        updated         | updatedby | isactive | ad_pinstance_para_id
-----------------+-------+-------------------------+-----------------------------------------+-------------+----------+-------------+--------+-----------+------------------------+---------+--------------+-----------+------------------------+-----------+------------------------+-----------+----------+----------------------
         1520068 |    40 | M_HU_PI_Item_Product_ID |                                         |             |      101 |           0 |        |           | No Packing Item        |         |      1000000 |   1000000 | 2017-08-01 13:08:35+02 |   2188223 | 2017-08-01 13:08:35+02 |   2188223 | Y        |              1524489
         1520068 |    50 | M_LU_HU_PI_ID           |                                         |             |  1000006 |           0 |        |           | EUR-Tauschpalette Holz |         |      1000000 |   1000000 | 2017-08-01 13:08:35+02 |   2188223 | 2017-08-01 13:08:35+02 |   2188223 | Y        |              1524490
         1520068 |    60 | QtyCU                   |                                         |             |        2 |             |        |           | 2                      |         |      1000000 |   1000000 | 2017-08-01 13:08:35+02 |   2188223 | 2017-08-01 13:08:35+02 |   2188223 | Y        |              1524491
         1520068 |    80 | QtyLU                   |                                         |             |        1 |             |        |           | 1                      |         |      1000000 |   1000000 | 2017-08-01 13:08:35+02 |   2188223 | 2017-08-01 13:08:41+02 |   2188223 | Y        |              1524493
         1520068 |    70 | QtyTU                   |                                         |             |        1 |             |        |           | 1                      |         |      1000000 |   1000000 | 2017-08-01 13:08:35+02 |   2188223 | 2017-08-01 13:08:35+02 |   2188223 | Y        |              1524492
         1520068 |    20 | $WEBUI_ViewId           | 540328-bc3ea4b1af844db3a0945173b0f99d9e |             |          |             |        |           |                        |         |      1000000 |   1000000 | 2017-08-01 13:08:29+02 |   2188223 | 2017-08-01 13:08:29+02 |   2188223 | Y        |              1524487
         1520068 |    30 | $WEBUI_ViewSelectedIds  | PP_Order_1000096                        |             |          |             |        |           |                        |         |      1000000 |   1000000 | 2017-08-01 13:08:29+02 |   2188223 | 2017-08-01 13:08:29+02 |   2188223 | Y        |              1524488
         1520068 |    10 | $WEBUI_ViewWindowId     | 540328                                  |             |          |             |        |           |                        |         |      1000000 |   1000000 | 2017-08-01 13:08:29+02 |   2188223 | 2017-08-01 13:08:29+02 |   2188223 | Y        |              1524486
(8 rows)

Next: evaluate the log's error message from the time that receipt failed

@metas-ts metas-ts self-assigned this Aug 2, 2017
@metasnw
Copy link
Member Author

metasnw commented Aug 2, 2017 •
edited
Loading

case 1 - receipt without sales order without CU-TU

  1. receive HU
    image
  2. NOK: reverse not possible
Ihr Test hat einen bisher unentdeckten Fehler offengelegt.
 Bitte leiten Sie diese Meldung an metas weiter: Assumption failure: tableName not empty

case 2 - receipt without sales order without CU-TU

  1. receive HU
    image
  2. NOK: reverse possible

metas-ts added a commit that referenced this issue Aug 3, 2017
@metas-ts
fix the pp-order-issue parameters
7e1dfb3 
LookupValue: IntegerLookupValue.of (constant!) values are declared as
"translated" see javadoc

WEBUI_PP_Order_Receipt etc
* changed parameters to allow specifying a TU and LU if there is none
given from the PP_Order

JSONViewRow: if no attributes are supported, then set that value to
false

528: Exception when opening PP Order issue / receipt 

Task-Url: #528
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Aug 3, 2017
@metas-ts
supportive work on the WEBUI-Process parameter issue
ec325d8 
the two I_PP_POrderX model classes: allow to get the
M_HU_LUTU_Configuration_ID without loading the whole thing

PPOrderBOMLineDocumentLUTUConfigurationHandler and
PPOrderDocumentLUTUConfigurationHandler:
* if the ppOrder or bomLine has a lutu-config, then use it!

HandlingUnitsDAO, HUPPOrderBL:
* Add javadoc and @nullable or @nonnull annotations, also remove some
Check.assumeNotNull()s in return

528: Exception when opening PP Order issue / receipt 

Task-Url: metasfresh/metasfresh-webui-api-legacy#528
metas-ts added a commit that referenced this issue Aug 3, 2017
@metas-ts
minor but imho still important: only issue active HUs..
5537da6 
528: Exception when opening PP Order issue / receipt

Task-Url: #528
metas-ts added a commit that referenced this issue Aug 10, 2017
@metas-ts
solve error "Assumption failure: tableName not empty"
3680e6f 
* solution: extend the API to support multi-table rows (take a look at
PPOrderLinesView.getTableNameOrNull())
* also renamed IView.getTableName() to getTableNameOrNull()

Exception when opening PP Order issue / receipt
#528
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Aug 29, 2017
@metas-ts
Allow virtual HU but help avoiding virtual CU on LU
5b094fa 
* LUTUConfigurationFactory.createLUTUConfiguration() add parameter to
allow *not* to set a LU config if the respective tuPIItemProduct is
virtual; 
* PPOrderBOMLineDocumentLUTUConfigurationHandler and
PPOrderDocumentLUTUConfigurationHandler: use the new feature of
LUTUConfigurationFactory to avoid having a virtual HU on a palet by
default
* InterfaceWrapperHelper: minor javadoc
* IHUPIItemProductDAO: make the constant value of the virtual piip
public
* HUTestHelper, HUShipmentScheduleBL,
LUTUConfigurationFactory_createLUTUProducerAllocationDestination_Test,
CustomerReturnLUTUConfigurationHandler, AbstractHUTestWithSampling,
AbstractHUDDOrderProcessIntegrationTest and
ReceiptScheduleDocumentLUTUConfigurationHandler: minor edits in many
places according to the new method param
* AbstractPPOrderReceiptHUProducer, ProcessPreconditionChecker and
ProcessDefaultParametersUpdater: minor

528: Exception when opening PP Order issue / receipt 

Task-Url: metasfresh/metasfresh-webui-api-legacy#528
metas-ts added a commit that referenced this issue Aug 29, 2017
@metas-ts
Solve bug of accidental "?" duplication
8d2db89 
528: Exception when opening PP Order issue / receipt 

Task-Url: #528
metas-ts added a commit that referenced this issue Aug 29, 2017
@metas-ts
Allow to receive into virtual PI, because that's not generally a problem
a74775c 
I think the actual problem was/is that we have an old bug around putting
a CU right onto a LU

* WEBUI_PP_Order_Receipt: allow to receive a (virtual) just-CU
* WEBUI_ProcessHelper: add option to also return the virtual-PI lookup
value
* PPOrderLinesView implement retrieveModelsbyId
* WEBUI_M_HU_ReverseReceipt avoid class cast exception in the context of
the production window (and maybe also the picking window)
* DocumentValidstatus: improve the not-valid message
* SqlViewSelectionQueryBuilder, WebuiHUTransformParametersFiller and
WEBUI_Picking_PickToNewHU: minor

528: Exception when opening PP Order issue / receipt 

Task-Url: #528
This was referenced Aug 29, 2017
Merged
Merged
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Aug 30, 2017
@metas-ts
minor javadoc addition
70529ac 
528: Exception when opening PP Order issue / receipt 

Task-Url: metasfresh/metasfresh-webui-api-legacy#528
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Aug 30, 2017
@metas-ts
fix/update unit test
8869fe5 
528: Exception when opening PP Order issue / receipt 

Task-Url: metasfresh/metasfresh-webui-api-legacy#528
metas-ts added a commit that referenced this issue Aug 30, 2017
@metas-ts
address multiple codacy and codebeat issues
eedbe12 
528: Exception when opening PP Order issue / receipt 

Task-Url: #528
metas-ts added a commit that referenced this issue Aug 30, 2017
@metas-ts
Merge pull request #552 from metasfresh/gh528-api
1db138c 
Exception when opening PP Order issue / receipt #528
@metas-ts metas-ts removed their assignment Aug 30, 2017
metas-ts added a commit that referenced this issue Aug 30, 2017
@metas-ts
Solve bug of accidental "?" duplication
1f1461b 
528: Exception when opening PP Order issue / receipt

Task-Url: #528
(cherry picked from commit 8d2db89)
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Aug 30, 2017
@metas-ts
add migration script for process param display logic
1901633 
528: Exception when opening PP Order issue / receipt 

Task-Url: metasfresh/metasfresh-webui-api-legacy#528
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Sep 1, 2017
@metas-ts
Update ReleaseNotes.md
8a86953 
[#553](metasfresh/metasfresh-webui-api-legacy#553)
webui notification-test fails
[#1157](metasfresh/metasfresh-webui-frontend-legacy#1157)
Delete User Notifications
[#2145](#2145) Partial
Internal usage action in Handling Unit Editor
 [#529](#529) Possibility
to easily create more than 1 referenced Doc per Invoice
 [#557](metasfresh/metasfresh-webui-api-legacy#557)
Picking Window: Open HU Selection window filtering
 [#560](metasfresh/metasfresh-webui-api-legacy#560)
Picking: don't allow picking included rows
[#556](metasfresh/metasfresh-webui-api-legacy#556)
Picking Window Main View adjustments
[#551](metasfresh/metasfresh-webui-api-legacy#551)
verify if lookup value is still valid
[#2237](#2237) Order
Control Report Attribute missing
[#528](metasfresh/metasfresh-webui-api-legacy#528)
Exception when opening PP Order issue / receipt
[#2102](#2102) maven
change "local" version from 1.0.0 to 10.0.0
[#1876](#1876) New CU
Labels
[#1142](metasfresh/metasfresh-webui-frontend-legacy#1142)
issue panel closes right after you issue a product
[#54](metasfresh/metasfresh-webui-api-legacy#54)
Implement endpoint for document cloning
[#549](metasfresh/metasfresh-webui-api-legacy#549)
Validcombination Window does not allow NEW in WebUI
[#2245](#2245) Replace
description field by memo in B2C
[#2258](#2258) add due
date to request grid view
[#2247](#2247) Make
Request Type a search field
[#2260](#2260) SQL -
problem to rollout master build to DB with issue-build

me-45
@metas-lc
Copy link

IT
opening and closing issue/receipt works OK
receiving a CU and removing it works OK
you cannot receive only on LU (you also have to add TU) OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch:master branch:release type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@metas-ts @metas-lc @metasnw