-
Notifications
You must be signed in to change notification settings - Fork 32
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
address multiple codacy and codebeat issues
528: Exception when opening PP Order issue / receipt Task-Url: #528
- Loading branch information
Showing
7 changed files
with
161 additions
and
133 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 changes: 94 additions & 0 deletions
94
src/main/java/de/metas/ui/web/handlingunits/process/WEBUI_M_HU_Receipt_Base.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| package de.metas.ui.web.handlingunits.process; | ||
|
|
||
| import org.adempiere.util.lang.MutableInt; | ||
|
|
||
| /* | ||
| * #%L | ||
| * metasfresh-webui-api | ||
| * %% | ||
| * Copyright (C) 2017 metas GmbH | ||
| * %% | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as | ||
| * published by the Free Software Foundation, either version 2 of the | ||
| * License, or (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public | ||
| * License along with this program. If not, see | ||
| * <http://www.gnu.org/licenses/gpl-2.0.html>. | ||
| * #L% | ||
| */ | ||
|
|
||
| import de.metas.process.IProcessPrecondition; | ||
| import de.metas.process.IProcessPreconditionsContext; | ||
| import de.metas.process.JavaProcess; | ||
| import de.metas.process.ProcessPreconditionsResolution; | ||
| import de.metas.ui.web.handlingunits.HUEditorRow; | ||
| import de.metas.ui.web.handlingunits.HUEditorView; | ||
| import de.metas.ui.web.process.ViewAsPreconditionsContext; | ||
|
|
||
| /** | ||
| * Common base class to dedupliate code. | ||
| * | ||
| * @author metas-dev <dev@metasfresh.com> | ||
| * | ||
| */ | ||
| public abstract class WEBUI_M_HU_Receipt_Base extends JavaProcess implements IProcessPrecondition | ||
| { | ||
| @Override | ||
| public ProcessPreconditionsResolution checkPreconditionsApplicable(final IProcessPreconditionsContext context) | ||
| { | ||
| final ViewAsPreconditionsContext viewContext = ViewAsPreconditionsContext.castOrNull(context); | ||
| if (viewContext == null) | ||
| { | ||
| return ProcessPreconditionsResolution.rejectWithInternalReason("webui view not available"); | ||
| } | ||
|
|
||
| final boolean isHUView = viewContext.getView() instanceof HUEditorView; | ||
| if (!isHUView) | ||
| { | ||
| return ProcessPreconditionsResolution.rejectWithInternalReason("The current view is not an HUEditorView; view=" + viewContext.getView() + ";"); | ||
| } | ||
|
|
||
| if (viewContext.isNoSelection()) | ||
| { | ||
| return ProcessPreconditionsResolution.rejectBecauseNoSelection(); | ||
| } | ||
|
|
||
| final MutableInt checkedDocumentsCount = new MutableInt(0); | ||
| final ProcessPreconditionsResolution firstRejection = viewContext.getView(HUEditorView.class) | ||
| .streamByIds(viewContext.getSelectedDocumentIds()) | ||
| .filter(document -> document.isPureHU()) | ||
| // | ||
| .peek(document -> checkedDocumentsCount.incrementAndGet()) // count checked documents | ||
| .map(document -> rejectResolutionOrNull(document)) // create reject resolution if any | ||
| .filter(resolution -> resolution != null) // filter out those which are not errors | ||
| .findFirst() | ||
| .orElse(null); | ||
| if (firstRejection != null) | ||
| { | ||
| // found a record which is not eligible => don't run the process | ||
| return firstRejection; | ||
| } | ||
| if (checkedDocumentsCount.getValue() <= 0) | ||
| { | ||
| return ProcessPreconditionsResolution.rejectWithInternalReason("no eligible rows"); | ||
| } | ||
|
|
||
| return ProcessPreconditionsResolution.accept(); | ||
| } | ||
|
|
||
| /** | ||
| * Check the individual given row, to find out if this process can be applied to it or not. | ||
| * | ||
| * @param document | ||
| * @return | ||
| */ | ||
| abstract ProcessPreconditionsResolution rejectResolutionOrNull(HUEditorRow document); | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.