Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Included views are not working in non-modal windows #1239

Closed
teosarca opened this issue Oct 6, 2017 · 12 comments
Closed

Included views are not working in non-modal windows #1239

teosarca opened this issue Oct 6, 2017 · 12 comments
Labels
branch:master branch:release priority:high type:bug

Comments

@teosarca
Copy link
Member

teosarca commented Oct 6, 2017

Is this a bug or feature request?

Bug

Which are the steps to reproduce?

What is the expected or desired behavior?

It shall open the included view because:

  • layout says so:
    image

  • retrieved rows have the includedView property set:
    image

Modal version, for comparison

image

image
@teosarca
Copy link
Member Author

teosarca commented Oct 6, 2017

required for metasfresh/metasfresh#518

@ottosichert ottosichert self-assigned this Oct 6, 2017
@ottosichert ottosichert mentioned this issue Oct 6, 2017
Merged
@ottosichert
Copy link
Contributor

I created a PR for this (#1241). Looks like it didn't work because it was never implemented for non-modals.

The code for the includedView DocumentList is mostly repeated in modals and non-modals, so maybe a refactoring of includedView into DocumentList itself could be the next step.

Note: As this PR changes the behaviour of the Table and DocumentList component (thus most views in WebUI) I recommend thorough testing

@teosarca
Copy link
Member Author

teosarca commented Oct 9, 2017

Hi @ottosichert . Thanks for the quick fix.
I've integrated the task but i would like to ask u to fix following layout issue:

image

basically it shall look like the modal one:
image

@ottosichert
Copy link
Contributor

@teosarca I will submit a second PR this evening (german time) fixing the layout issue. Can you tell me how I can open the modal view so I can compare the results?

@teosarca
Copy link
Member Author

teosarca commented Oct 9, 2017 •
edited
Loading

@ottosichert

I will submit a second PR this evening (german time) fixing the layout issue.

danke

Can you tell me how I can open the modal view so I can compare the results?

now shall be available on w101

image

@teosarca teosarca mentioned this issue Oct 9, 2017
Closed
This was referenced Oct 9, 2017
Closed
Merged
@ottosichert
Copy link
Contributor

@teosarca See the PR #1245

I can not find the Browse picking slots button on w101 (https://w101.metasfresh.com:8443/window/540206?viewId=540206-3c8d679a206c4e4f8553756ecae616f7&page=1) or on master, do you know why? I logged in as user metasfresh

@teosarca
Copy link
Member Author

@ottosichert

about the button... it might be that user has no privileges to that action.
But i think it's not so important... (in meantime i've already deleted that action because we don't need it).
The layout shall just be divided in half and have the attributes panel hidden.
I think you already did that on PR #1245 .
But before i can integrate it can u pls check and resolve the conflict on DocList.js file.

Thanks.

@metas-rc metas-rc assigned metas-rc and unassigned metas-rc Oct 11, 2017
@ottosichert
Copy link
Contributor

@teosarca I resolved the merge conflict in #1245 and rebased the branch with master

@teosarca
Copy link
Member Author

thanks, integrated

@ottosichert ottosichert mentioned this issue Oct 11, 2017
Closed
@metas-rc metas-rc self-assigned this Oct 12, 2017
@metas-rc
Copy link
Member

Results of IT

  • I went to Picking Tray window and clicked on one line there.
  • OK: The included view was opened
  • Then I clicked the home button and got to another window (e.g. Request)
  • NOK: The included view from the picking remains open.

@metas-rc
Copy link
Member

image

image

image

@metas-rc metas-rc removed their assignment Oct 12, 2017
@ottosichert ottosichert mentioned this issue Oct 12, 2017
Merged
@metas-rc
Copy link
Member

Results of IT

  • OK: Now the included view dissapears when I open another menu entry.

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Oct 13, 2017
@metas-ts
Update ReleaseNotes.md
ab1e816 
[#2699](#2699) NPE when
pressing Complete for an invoice with no lines
[#2700](#2700) Set
correct identifiers in the table M_ShipmentSchedule
[#2643](#2643) Forecast
in Material Disposition
[#628](metasfresh/metasfresh-webui-api-legacy#628)
Extend framework to allow modification of standard filter results
[#1239](metasfresh/metasfresh-webui-frontend-legacy#1239)
Included views are not working in non-modal windows
[#2711](#2711)
productdescription in sales order jasper
[#2645](#2645) Source HU
Automatism for Manufacturing Issue
[#2400](#2400) discount
in manual sales invoice
[#518](#518) Easier
solution to clear the Picking Slots
[#1216](metasfresh/metasfresh-webui-frontend-legacy#1216)
hu lines appear only after refresh
[#2704](#2704) Show an
explicit error message when reports don't open because of logo missing
[#2693](#2693)
C_Flatrate_Conditions.C_Flatrate_Transition_ID needs to be mandatory
[#1224](metasfresh/metasfresh-webui-frontend-legacy#1224)
Error when pressing Action after completing an invalid document
[#1232](metasfresh/metasfresh-webui-frontend-legacy#1232)
Labels widget: keyboard support

me-45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
branch:master branch:release priority:high type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@teosarca @ottosichert @metas-ts @metas-rc