Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Opening a new included view is broken #1243

Closed
teosarca opened this issue Oct 9, 2017 · 8 comments
Closed

Opening a new included view is broken #1243

teosarca opened this issue Oct 9, 2017 · 8 comments

Comments

@teosarca
Copy link
Member

teosarca commented Oct 9, 2017

Is this a bug or feature request?

bug

Which are the steps to reproduce?

*in the Picking modal window, make sure you have a line selected on left side and on right side (by default it is) and call "Open HU selection window".
image

=> remark that the right side panel remains empty even though the frontend is fetching the layout and data.

image

What is the expected or desired behavior?

the included view shall be displayed.

@teosarca
Copy link
Member Author

teosarca commented Oct 9, 2017

might be related to #1239

@ottosichert
Copy link
Contributor

Can confirm it was introduced by #1239, resolving it now

metas-mk added a commit to metasfresh/metasfresh that referenced this issue Oct 11, 2017
Adding Bugfix Issue to the Release 5.31
metasfresh/metasfresh-webui-frontend-legacy#1243
Opening a new included view is broken
@metas-rc
Copy link
Member

Results of IT

  • After I click on Pick and I select the liine, I cannot see the picking slots in the right side.
    image

  • I also get the following error in the console:

DocumentList.js:521 Uncaught TypeError: Cannot read property 'windowId' of undefined
at value (DocumentList.js:521)
at onMouseDown (Table.js:885)
at Object.invokeGuardedCallback (ReactErrorUtils.js:26)
at executeDispatch (EventPluginUtils.js:85)
at Object.executeDispatchesInOrder (EventPluginUtils.js:108)
at executeDispatchesAndRelease (EventPluginHub.js:43)
at executeDispatchesAndReleaseTopLevel (EventPluginHub.js:54)
at Array.forEach ()
at forEachAccumulated (forEachAccumulated.js:24)
at Object.processEventQueue

@ottosichert
Copy link
Contributor

ottosichert commented Oct 11, 2017

EDIT: See my answer for a detailed description of previous comment #1243 (comment)

Looks like there is a new issue since last rollout:

The attributes supportIncludedViews and includedView are missing for data in Picking Terminal > Picking modal window

bildschirmfoto vom 2017-10-11 18-21-26
(https://w101.metasfresh.com:8443/window/540345?page=1&viewId=540345-5a70ffcc5fe9444db0a61eeb2890a2a1)

In Picking Tray the data still has those attributes:

bildschirmfoto vom 2017-10-11 18-21-44
(https://w101.metasfresh.com:8443/window/540206?page=1&viewId=540206-8570050490ab451da17059cd19d5ca56)

This causes the Picking modal window to fail completely!

@ottosichert
Copy link
Contributor

@teosarca Do you know if the above issue is related to metasfresh/metasfresh-webui-api-legacy@fb46903#diff-f6787b10539a146649cf3ed8c1cbd61aR88? If so, can you take a look or tell me, where the associated includedView will come from?

@teosarca
Copy link
Member Author

@ottosichert might be, have to check.

@teosarca
Copy link
Member Author

teosarca commented Oct 12, 2017

@ottosichert @metas-rc fixed and rolled out on w101. Shall be OK now.

@metas-rc
Copy link
Member

Results of IT2

  • OK: After I click on Pick and I select the line, the picking slots in the right side are now displayed.
  • OK: When I click Open HU selection window and I have no HUs I get the " There are no detail rows. You can create them in this window."
  • OK: If I have HUs, the HUs editor opens and all the specific actions from HUs are available for the entries.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants