Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

View field editor: number field is behaving weird when using keyboard #1358

Closed
teosarca opened this issue Nov 20, 2017 · 8 comments
Closed

View field editor: number field is behaving weird when using keyboard #1358

teosarca opened this issue Nov 20, 2017 · 8 comments
Assignees
@wiadev
Labels
branch:master branch:release priority:high type:bug

Comments

@teosarca
Copy link
Member

teosarca commented Nov 20, 2017 •
edited
Loading

Is this a bug or feature request?

Bug

follow up of #1335

What is the current behavior?

Which are the steps to reproduce?

Remark:

  1. click left/right to move your cursor inside the number field => not working
  2. DEL, BACKSPACE not working
  3. CTRL+A not working
  4. press arrow UP/DOWN. Sometimes the number is incremented and sometimes the current selected row is changed. When the current selected row is changed (e.g. press UP and the row above is now the current selected row) the editor value is not sent back to backend.

NOTE: sometimes works sometimes not.... play a bit with them.

image

What is the expected or desired behavior?

All the points above shall work.
@wiadev wiadev self-assigned this Nov 21, 2017
@teosarca
Copy link
Member Author

@wiadev about sending all edited values when user presses Done, we have a similar issue on process parameters: #1331 (comment)

@teosarca teosarca mentioned this issue Nov 21, 2017
Open
@teosarca
Copy link
Member Author

@wiadev also pls consider the problems described here: #1274

This was referenced Nov 21, 2017
Closed
Closed
wiadev added a commit that referenced this issue Nov 21, 2017
@wiadev
Fix keyboard behaviour on field editor & table #1358
e66d0fb
@wiadev wiadev mentioned this issue Nov 21, 2017
Merged
teosarca added a commit that referenced this issue Nov 22, 2017
@teosarca
Merge pull request #1370 from metasfresh/dev-1358
851665e 
Fix keyboard behaviour on field editor & table #1358
@metas-lc metas-lc self-assigned this Nov 23, 2017
@metas-lc
Copy link

metas-lc commented Nov 23, 2017 •
edited
Loading

IT
(for this task, please check NOK from: 4? , 5?, 7, 10. no. 10 is the most important! You can create followups for the rest if they are not related)

  1. each time you modify something you get "Row does not support attributes" error in Preview and console (for the view) - probably will be fixed in Don't use the legacy view attributes API #1357

  2. click left/right to move your cursor inside the number field => click works OK

  3. DEL, BACKSPACE - working OK but if i use them the last number appears back - follow-up cannot completely delete a numeric field in grid view #1383

  4. CTRL+A not working - changed to alt a - not working (probably not related with this task?) "WindowId cannot be converted to int: SO2PO"

  5. press arrow UP/DOWN. - only the current selected row is changed OK
    (managed to change the row using up and down arrow while i was updating date field NOK)

  6. Between "/window/" and "/SO2OLCand" we have the viewId. OK

  7. if I press enter, the patch is not sent to server => NOK
    (noticed that tab works)

  8. if i press on component's arrow up/down to increment/decrement the number=> the patch is sent (you do have to press somewhere else..or done) OK

  9. after you make changes and press done, the view is requerried NOK - followup: don't requerry closed view #1384

  10. About patch not being sent to the server.. the following happend to a different chrome version:
    patch
    NOK
    Chrome version: 60.0.3112.113 (Official Build) (64-bit)
    the qty send was not the correct one
    please make sure that when you press done, to send everything that needs to be send

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Nov 26, 2017
@metas-ts
update ReleaseNotes.md
bfa6bcb 
[#1293](metasfresh/metasfresh-webui-frontend-legacy#1293)
Cannot scroll down in a filter with lots of parameters
[#669](metasfresh/metasfresh-webui-api-legacy#669)
CU-TU's built name and description is wrong
[#1366](metasfresh/metasfresh-webui-frontend-legacy#1366)
Error in Quickentry dropdown List
[#1345](metasfresh/metasfresh-webui-frontend-legacy#1345)
Invalid date was used on dateTime tablecell
[#701](metasfresh/metasfresh-webui-api-legacy#701)
webui server is losing session context
[#683](metasfresh/metasfresh-webui-api-legacy#683)
Source HU Actions shall only be "Drop Source HU"
[#1358](metasfresh/metasfresh-webui-frontend-legacy#1358)
View field editor: number field is behaving weird when using keyboard
[#2945](#2945) Adjustment
in pain001
[#3056](#3056) purchase
candidates: implement locking mechanism
[#694](metasfresh/metasfresh-webui-api-legacy#694)
purchase view: set modal title as process caption
[#700](metasfresh/metasfresh-webui-api-legacy#700)
Filter error after static filter set
[#3057](#3057) display
order, forecast or shipmentschedule in material dispo main window
[#3055](#3055) purchase
candidates: notify user when the purchase order was generated
[#697](metasfresh/metasfresh-webui-api-legacy#697)
New BPartner is not available as SubProducerBPartner in MaterialReceipt
BPartner
[#3034](#3034) solve
material dispo regressions
[#671](metasfresh/metasfresh-webui-api-legacy#671)
T_WEBUI_ViewSelection[Line] shall be truncated and not deleted
[#695](metasfresh/metasfresh-webui-api-legacy#695)
picking terminal: implement dynamic picking slot allocation/release
[#3043](#3043) A contract
shall not be created when a completing a quotation
[#1380](metasfresh/metasfresh-webui-frontend-legacy#1380)
Shortcut for new document
[#2944](#2944) Allow more
than 1 PostFinanceUserNo per Account
[#3023](#3023) ad_org is
ignored when doing quick order entry
[#1363](metasfresh/metasfresh-webui-frontend-legacy#1363)
jenkins: run npm test on each build
[#3010](#3010) Inherit
c_order_id and orderline_id from flatrate term to invoice candidate
[#2958](#2958) 2nd
Discount Break is ignored
[#2997](#2997) Partner
Import: Support importing the Org via value
[#689](metasfresh/metasfresh-webui-api-legacy#689)
Picking processed compress to top-level HU
[#692](metasfresh/metasfresh-webui-api-legacy#692)
Error in Quickentry Sales Order when canceling input
[#679](metasfresh/metasfresh-webui-api-legacy#679) HU
taken out in Picking Tray Clearing still displayed in the Picking Slot
in Picking Terminal
[#687](metasfresh/metasfresh-webui-api-legacy#687)
picking terminal: show BPartner instead of DeliveryDate
[#693](metasfresh/metasfresh-webui-api-legacy#693)
Error in create purchase orders from Sales order line
[#662](metasfresh/metasfresh-webui-api-legacy#662)
Aggregate Storage for Product and Warehouse
[#1351](metasfresh/metasfresh-webui-frontend-legacy#1351)
wrong backend api call for grid view editing

me-45
@wiadev
Copy link
Contributor

wiadev commented Nov 30, 2017

@teosarca regarding #10 which is related with #7, right now, under table hierarchy, they do have all handleKeyword methods and one of them is handling 'enter', as well and blocking the other 'enter' key strokes.

and moreover, there is no watcher for 'enter' hit on input number field ( of RawWidget ) and which should be implemented newly.

I suggest to create new follow-up task for this, as well.

@teosarca
Copy link
Member Author

@wiadev can u pls that follow-up task and extract there the issues enumerated by @metas-lc (Lili) which were not delivered here?

@wiadev wiadev mentioned this issue Nov 30, 2017
Closed
@wiadev
Copy link
Contributor

wiadev commented Nov 30, 2017 •
edited
Loading

  1. if I press enter, the patch is not sent to server => NOK
    (noticed that tab works)

follow-up - #1396

@teosarca
Copy link
Member Author

i guess everything was delivered on this task.

@metas-lc metas-lc mentioned this issue Dec 15, 2017
Closed
@metas-lc
Copy link

IT
checked again the testcase above

  1. "Row does not support attributes" error is now gone OK
  2. still working OK
  3. delete and backspace still shows the number NOK broke: cannot completely delete a numeric field in grid view #1462
  4. alt+a works OK
  5. press arrow UP/DOWN - same issue, you can change the row if you are in date field NOK
    probably shall be fixed by Left and right key doesn't work on date edit field #1429
  6. OK
  7. we have task Cases when Patch request isn't sent after hit enter #1430
  8. and 9. have task, rest is ok don't requerry closed view #1384
  9. i'll update the task from step 9. shall be fixed there

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wiadev wiadev

Labels
branch:master branch:release priority:high type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@teosarca @metas-ts @metas-lc @wiadev