Don't use the legacy view attributes API

[teosarca]

Instead of using
http://w101.metasfresh.com:8081/swagger-ui.html#/view-row-attributes-rest-controller-_-old

please always use
http://w101.metasfresh.com:8081/swagger-ui.html#/view-row-attributes-rest-controller

That legacy API is scheduled to be deleted. It already caused a lot of confusion.

Note to IT:

• check view attributes (setting, dropdown) => no errors
• briefly test creating a new document (e.g. a new sales order) => no errors

[teosarca]

@wiadev also check the documentation/discussion from #1184 (duplicate of this one)

[wiadev]

@teosarca fixed calling wrong api after editing/patching on the following modal under this task we discussed last time.

can you give me the use cases using old apis?

[metas-lc]

how to test attributes

1. go to receipt candidates window: https://w101.metasfresh.com:8443/window/540196?viewId=540196-06faf33c94f14604ac8662311a3055a8&page=1
2. select any line (e.g. one for convenence salad)
3. select the main action (e.g. green button: 1 IFCO 6410 x 10 Stk)
4. modify some attributes while being on LU level:
   =>
   when you edit gewicht brutto notice gewicht netto updates
   when you update tageslot lot-nummer updates
   most attributes you modify on LU level, will update on TU level as well
   cu level doesn't support attributes

[wiadev]

@teosarca can you point out where I can find subentity/subentityId apis on swagger ui doc?
Also, usage of isAdvanced query param.

[teosarca]

@wiadev let's talk when u have time. I don't understand your request :(

[wiadev]

another use case to get attributes after discussing with @teosarca
https://w101.metasfresh.com:8443/window/540189

[wiadev]

@teosarca

check out the above screenshot and could you point out why it doesn't work?

[wiadev]

@teosarca same issue on http://localhost:3000/window/540189?viewId=540189-d9970cd0d9764f67b6d1e44bfbfba4b7&page=1 when I select the last includedDocument.

[teosarca]

@wiadev

check out the above screenshot and could you point out why it doesn't work?
same issue on http://localhost:3000/window/540189?viewId=540189-d9970cd0d9764f67b6d1e44bfbfba4b7&page=1 when I select the last includedDocument.

Yup that's happening because the row level supportAttributes property is not considered.
See task: #1393

[wiadev]

@teosarca understood
since we have a new follow-up issue, can we close this issue after merge #1392 ?

[teosarca]

@wiadev nop, the issue will be closed by the integration testing team after they will perform all tests + regression.
That's our standard procedure.

[teosarca]

but they will know about that follow-up and will not fail the task because of that.

[wiadev]

@teosarca got it.
I meant by moving to testing team.

[teosarca]

yes, ofc.
but before i will do some quick preliminary tests. One thing that i forgot to tell you and now pops in my mind, and I HOPE it's not related is about editing product attributes.

e.g.

[teosarca]

update: it seems the view attributes code has nothing to do with product attributes (the ones from above). So it's fine.
@wiadev can u also confirm this?

[wiadev]

@teosarca confirmed that viewAttributes code has nothing to do with product attributes.
It's using another getAttributeInstances() methods which is POST /api/pattribute

[teosarca]

@wiadev perfect, 10x.

[metas-ts]

cherry-picked into the release branch

[metas-ts]

CPed the remaining commits to release too

[metas-rc]

Note: IT only after #1441 is properly integrated.

[metas-lc]

IT
tested attributes in orderlines, manufacturing OK
tested in hu editor from material receipt OK
made a task for a special case: #1468
in hu editor, if you set an attribute from none (null) to none you get an error