Revamp getViewAttributes() method

metasfresh · Nov 30, 2017 · e0eed6c · e0eed6c · metas-ts · Dec 8, 2017
1 parent 55a13af
commit e0eed6c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 12 deletions.
diff --git a/src/actions/GenericActions.js b/src/actions/GenericActions.js
@@ -39,21 +39,20 @@ export function getData(
 }
 
 /**
- * 
- * @param {*} entity - entity should always be `documentView`
- * @param {*} windowId 
- * @param {*} viewId 
- * @param {*} rowId 
+ *
+ * @param {*} windowId
+ * @param {*} viewId
+ * @param {*} rowId
  */
-export function getAttributes(
-    entity, windowId, viewId, rowId
+export function getViewAttributes (
+    windowId, viewId, rowId
 ) {
     return axios.get(
         config.API_URL +
-        '/' + entity +
+        '/documentView'+
         '/' + windowId +
-        (viewId ? '/' + viewId : '') +
-        (rowId ? '/' + rowId : '') +
+        '/' + viewId +
+        '/' + rowId +
         '/attributes'
     );
 }

diff --git a/src/components/app/SelectionAttributes.js b/src/components/app/SelectionAttributes.js
@@ -4,7 +4,7 @@ import counterpart from 'counterpart';
 
 import {
     initLayout,
-    getAttributes
+    getViewAttributes
 } from '../../actions/GenericActions';
 
 import RawWidget from '../widget/RawWidget';
@@ -41,7 +41,7 @@ class SelectionAttributes extends Component {
         initLayout(entity, windowType, selected[0], null, viewId)
             .then(response => {
                 DLWrapperSetLayout(response.data.elements);
-                return getAttributes(entity, windowType, viewId, selected[0]);
+                return getViewAttributes(windowType, viewId, selected[0]);
             }).then(response => {
                 DLWrapperSetData(response.data.fieldsByName, response.data.id);
             }).catch(() => {});