Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Sequence of Dropdowns in combined Business Partner Lookups not working #1923

Closed
metas-mk opened this issue Aug 17, 2018 · 6 comments
Closed

Comments

@metas-mk
Copy link
Member

Is this a bug or feature request?

Bug

What is the current behavior?

In combined Business Partner Lookup Fields the implemented behavior sequence is not working anymore. The behavior was depending on

  • multiple locations for a Buisiness Partner
  • multiple contacts for a Buisiness Partner

Which are the steps to reproduce?

Open Sales Order window and try.

What is the expected or desired behavior?

Shall work again.

@metas-lc
Copy link

for IT: pls retest #1672

@siemiatj
Copy link
Contributor

siemiatj commented Aug 17, 2018

This should already be fixed with my yesterday's changes.

metas-mk added a commit to metasfresh/metasfresh that referenced this issue Aug 25, 2018
Adds new Issue
metasfresh/metasfresh-webui-frontend-legacy#1923
Sequence of Dropdowns in combined Business Partner Lookups not working
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Aug 27, 2018
[#4492](#4492) Project Status and Product Category Trl
[#4494](#4494) Projecttype Org Validation
[#4448](#4448) Advanced BLs to create inventory lines
[#4450](#4450) Tablet optimized inventory-counting-window
[#4482](#4482) Support Doctype Text templates also on purchase order
[#4498](#4498) Make fields in explicit user filter mandatory or optional
[#4501](#4501) LogicExpressionEvaluator: improve error message in case something went wrong
[#4517](#4517) Extend Sales Order REST API to support price and support all product values
[#1878](metasfresh/metasfresh-webui-frontend-legacy#1878) Forgot password feature
[#4483](#4483) Payment allocation form does not show invoices
[#4499](#4499) Cannot create letter
[#4504](#4504) Mandatory logic broken for C_FlatrateTerm.C_Currency_ID
[#4506](#4506) Compensation Group's subtotals gets broken after setting/changing the flatrate conditions
[#4509](#4509) NPE in Compensation Groups creation
[#4514](#4514) Include sales orders REST API to metasfresh-dist/serverRoot
[#1188](metasfresh/metasfresh-webui-frontend-legacy#1188) Home and End button move caret in text fields
[#1463](metasfresh/metasfresh-webui-frontend-legacy#1463) Unable to execute any quick actions in Firefox
[#1578](metasfresh/metasfresh-webui-frontend-legacy#1578) Applied filter params sometimes not displayed in filter
[#1589](metasfresh/metasfresh-webui-frontend-legacy#1589) included tab: when refreshing via websocket event the sort/order is not preserved
[#1707](metasfresh/metasfresh-webui-frontend-legacy#1707) Red line is missing when a document was not saved
[#1872](metasfresh/metasfresh-webui-frontend-legacy#1872) [alt]+u not working as before
[#1923](metasfresh/metasfresh-webui-frontend-legacy#1923) Sequence of Dropdowns in combined Business Partner Lookups not working
[#1927](metasfresh/metasfresh-webui-frontend-legacy#1927) No additional filter parameter from a dropdown selectable when filter has a default value set
@metas-dh
Copy link
Member

Results of IT1
tested in mf15

Sequence of Dropdowns in combined Business Partner Lookups:
I. business partner:

a. location:

  1. dropdown for location opens: OK
  2. ship-to location is pre-set, but was not the default ship-to location every time: NOK
  3. dropdown shows all locations, but not with the default one first every time: NOK
  4. dropdown shows all locations, also a location that's no ship-to location: NOK

b. contact:

  1. dropdown for contact opens after setting ship-to location: OK
  2. no contact is pre-set, also not the default ship-to contact: NOK
  3. dropdown shows all contacts, but not with the default ship-to contact first: NOK
  4. dropdown shows all contacts, also a contact that was no sales contact: NOK
  5. when using down arrow for going down the contacts dropdown, the dropdown for location is opened again and changed together with the contact: NOK, http://recordit.co/d0iW0awIec

=> works when using mouse or Enter, but when using Tab you don't get to the next dropdown, but to invoice partner: NOK => #1935

II. invoice partner:

a. location:

  1. dropdown only opens when you click actively on e.g. location (when you use Enter to confirm the billpartner; when you set the billpartner manually the dropdown opens): OK?
  2. default invoice location is pre-set: OK
  3. dropdown shows only the bill-to locations: OK
  4. dropdown shows only the bill-to locations, but not with the default one first every time: NOK

b. contact:

  1. dropdown for contact opens after setting bill-to location: OK
  2. no contact is pre-set, also not the default one: OK? (not sure this is a new problem related to this task)
  3. dropdown shows all contacts, but not with the default bill-to contact first: NOK
  4. dropdown shows all contacts, also a contact that is no sales contact: NOK

=> works when using mouse or Enter, but when using Tab you don't get to the next dropdown, but to warehouse: NOK => #1935

@siemiatj siemiatj self-assigned this Aug 28, 2018
@siemiatj
Copy link
Contributor

siemiatj commented Aug 28, 2018

I.
a.
2. can't repro, looks good every time here. Any particular business partner this breaks for ?
3. confirmed for 1000010_Machine Parts Ltd.
4. I'm only displaying on the client what I got from the server, so looks like a backend task. (backend ?)

b.
2,3. AD_User_ID is not sent from server with response. (backend ?)
4. Data controlled by the backend. (backend ?)
5. Can't repro : http://recordit.co/aMQpHdjFTJ

II.
a.
4. Can't repro but I'll assume this happens for the same reason it happens in I.a.3

b.
2,3,4. I don't have data for this with the previous response so can't preselect anything and no default value is given. (backend ?)

@teosarca @metas-ts Can you confirm those things are backend realted ?

#1935 will be handled with this effort

@teosarca
Copy link
Member

@siemiatj @metas-dh

agree about those backend issues. Frontend is not aware of the meaning of the data.

@metas-dh
Copy link
Member

metas-dh commented Sep 11, 2018

Results of IT2
tested in mf15

I.
a.
2. ship-to location is pre-set, with the default ship-to location every time: => this works fine as long the default location is not changed, so i guess this is also backend?
3. dropdown shows all locations, with the default one first every time: OK
b.
5. when using down arrow for going down the contacts dropdown, the dropdown for location is opened again and changed together with the contact: could not reproduce this anymore, so i guess it's fine / fixed now
II.
a.
4. dropdown shows only the bill-to locations, with the default one first every time: OK

=> closing this one since the frontend issues were fixed / not reproducable anymore and the remaining issues are backend ones.

@teosarca do we already have a task for the backend issues?

=> metasfresh/metasfresh-webui-api-legacy#1053

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants