Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compensation Group's subtotals gets broken after setting/changing the flatrate conditions #4506

Closed
teosarca opened this issue Aug 22, 2018 · 2 comments
Closed

Compensation Group's subtotals gets broken after setting/changing the flatrate conditions #4506

teosarca opened this issue Aug 22, 2018 · 2 comments
Assignees
@teosarca @metas-dh
Labels
branch:release bug_please_use_type:bug_instead priority:high type:bug

Comments

@teosarca
Copy link
Member

Is this a bug or feature request?

Bug

What is the current behavior?

Which are the steps to reproduce?

What is the expected or desired behavior?
@teosarca teosarca self-assigned this Aug 22, 2018
teosarca added a commit that referenced this issue Aug 22, 2018
@teosarca
introduce GroupMatcher; use GroupTemplateId
1ed947f 
#4506
teosarca added a commit that referenced this issue Aug 22, 2018
@teosarca
GroupCompensationLine: baseAmt shall be null in case of PriceQty type
3475f40 
Be consistent with setBaseAmt where an error is thrown if type is not Percentage

#4506
teosarca added a commit that referenced this issue Aug 22, 2018
@teosarca
avoid handling order line deletion in case the delete was triggered b…
c4750e8 
…y repository

#4506
@metas-dh metas-dh self-assigned this Aug 23, 2018
@metas-dh
Copy link
Member

Results of IT1
tested in mf15

SetUp:
1 flatrate term X, with period: weekly delivery for 1 month
2. compensation group schema A, including:

  • discount line, to set manual discount
  • flatrate discount, for flatrate term X, discount: 50%

Test:

  1. sales order with sev. orderlines, with TestProduct: qty:5
  2. run Multigroup lines process:
  • orderlines are grouped acc. to compensation group schemas, OK
  • discount line for manual discount is added, OK
  1. set flatrate term X for the TestProduct:
  • set for the discount line as well, OK
  • discount from flatrate term: 50%, OK
  • TestProduct qty price unit: now 25 (=> original qty:5 x 5 from weekly delivery for 1 month): is that OK?

2018-08-23 11_55_30-metasfresh

  1. delete all additional lines, run Multigroup lines process again
  2. set manual discount: 10% in discount line:
  • 10% discount are set: OK

2018-08-23 12_11_51-

  1. set flatrate term X for the TestProduct:
  • set for the discount line as well, OK
  • TestProduct qty price unit: now 25 (=> original qty:5 x 5 from weekly delivery for 1 month): is that OK?
  • manual discount of 10% is set back to 0: is that OK?
    2018-08-23 12_14_44-

@teosarca

  • i don't think the change of qty price unit for the product is ok, but there already is an old task about that: Quantity in Price Unit recalculated for flatrate term #3052, so it's probably nothing to do with this task?
  • is the manual discount supposed to be set back to 0 after adding a flatrate term for the group?

metas-ts added a commit that referenced this issue Aug 27, 2018
@metas-ts
Update ReleaseNotes.md
ef0a486 
[#4492](#4492) Project Status and Product Category Trl
[#4494](#4494) Projecttype Org Validation
[#4448](#4448) Advanced BLs to create inventory lines
[#4450](#4450) Tablet optimized inventory-counting-window
[#4482](#4482) Support Doctype Text templates also on purchase order
[#4498](#4498) Make fields in explicit user filter mandatory or optional
[#4501](#4501) LogicExpressionEvaluator: improve error message in case something went wrong
[#4517](#4517) Extend Sales Order REST API to support price and support all product values
[#1878](metasfresh/metasfresh-webui-frontend-legacy#1878) Forgot password feature
[#4483](#4483) Payment allocation form does not show invoices
[#4499](#4499) Cannot create letter
[#4504](#4504) Mandatory logic broken for C_FlatrateTerm.C_Currency_ID
[#4506](#4506) Compensation Group's subtotals gets broken after setting/changing the flatrate conditions
[#4509](#4509) NPE in Compensation Groups creation
[#4514](#4514) Include sales orders REST API to metasfresh-dist/serverRoot
[#1188](metasfresh/metasfresh-webui-frontend-legacy#1188) Home and End button move caret in text fields
[#1463](metasfresh/metasfresh-webui-frontend-legacy#1463) Unable to execute any quick actions in Firefox
[#1578](metasfresh/metasfresh-webui-frontend-legacy#1578) Applied filter params sometimes not displayed in filter
[#1589](metasfresh/metasfresh-webui-frontend-legacy#1589) included tab: when refreshing via websocket event the sort/order is not preserved
[#1707](metasfresh/metasfresh-webui-frontend-legacy#1707) Red line is missing when a document was not saved
[#1872](metasfresh/metasfresh-webui-frontend-legacy#1872) [alt]+u not working as before
[#1923](metasfresh/metasfresh-webui-frontend-legacy#1923) Sequence of Dropdowns in combined Business Partner Lookups not working
[#1927](metasfresh/metasfresh-webui-frontend-legacy#1927) No additional filter parameter from a dropdown selectable when filter has a default value set
teosarca added a commit that referenced this issue Sep 5, 2018
@teosarca
always set GroupCompensationBaseAmt even for price/qty compensation l…
63a85e2 
…ines

#4506
teosarca added a commit that referenced this issue Sep 12, 2018
@teosarca
fixes
9082cc0 
* update on compensation type /amtType changed
* on saving compensation line, update LineNetAmt

#4506
@teosarca teosarca reopened this Sep 12, 2018
@metas-dh
Copy link
Member

checked with metas-mk: OK, tested & rolled out at customer, working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teosarca teosarca

@metas-dh metas-dh

Labels
branch:release bug_please_use_type:bug_instead priority:high type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teosarca @metas-ts @metas-dh