Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mandatory logic broken for C_FlatrateTerm.C_Currency_ID #4504

Closed
cristinamghita opened this issue Aug 22, 2018 · 1 comment
Closed

Mandatory logic broken for C_FlatrateTerm.C_Currency_ID #4504

cristinamghita opened this issue Aug 22, 2018 · 1 comment

Comments

@cristinamghita
Copy link
Member

cristinamghita commented Aug 22, 2018

Is this a bug or feature request?

Bug

What is the current behavior?

 Document - Failed evaluating mandatory logic @PriceActual@!@null@ for DocumentField{fieldName=C_Flatrate_Term.C_Currency_ID, value=IntegerLookupValue{id=102, displayName=trl{trls={en_US=EUR}, default=EUR}}, initalValue=IntegerLookupValue{id=102, displayName=trl{trls={en_US=EUR}, default=EUR}}}. Preserving FALSE{mandatory-initial}
org.adempiere.ad.expression.exceptions.ExpressionEvaluationException: Parameter 'null' not found in context
 Context: DocumentEvaluatee{Document{tableName=C_Flatrate_Term, id=1000415, windowNo=2, writable=false, valid=Invalid-Initial('not validated yet'), validOnCheckout=Invalid-Initial('not validated yet'), saveStatus=DocumentSaveStatus{saved=false, deleted=false, hasChangesToBeSaved=true, error=false, reason=not yet checked}, saveStatusOnCheckout=DocumentSaveStatus{saved=false, deleted=false, hasChangesToBeSaved=true, error=false, reason=not yet checked}}}
 Evaluator: ExpressionEvaluationContext{onVariableNotFound=Fail, params=DocumentEvaluatee{Document{tableName=C_Flatrate_Term, id=1000415, windowNo=2, writable=false, valid=Invalid-Initial('not validated yet'), validOnCheckout=Invalid-Initial('not validated yet'), saveStatus=DocumentSaveStatus{saved=false, deleted=false, hasChangesToBeSaved=true, error=false, reason=not yet checked}, saveStatusOnCheckout=DocumentSaveStatus{saved=false, deleted=false, hasChangesToBeSaved=true, error=false, reason=not yet checked}}}}
	at org.adempiere.ad.expression.api.impl.LogicExpressionEvaluator$ExpressionEvaluationContext.resolveCtxName(LogicExpressionEvaluator.java:596)
	at java.util.HashMap.computeIfAbsent(HashMap.java:1126)
	at org.adempiere.ad.expression.api.impl.LogicExpressionEvaluator$ExpressionEvaluationContext.getValue(LogicExpressionEvaluator.java:555)

Which are the steps to reproduce?

Open window Contracts and check the trace.

What is the expected or desired behavior?

No error in console.

@cristinamghita cristinamghita self-assigned this Aug 22, 2018
cristinamghita added a commit that referenced this issue Aug 22, 2018
#4504 Mandatory logic broken for C_FlatrateTerm.C_Currency_ID
teosarca added a commit that referenced this issue Aug 22, 2018
@metas-dh
Copy link
Member

Results of IT1
tested in mf15

  • no error in console when opening contract window (neither Swing nor WebUI): OK

metas-ts added a commit that referenced this issue Aug 27, 2018
[#4492](#4492) Project Status and Product Category Trl
[#4494](#4494) Projecttype Org Validation
[#4448](#4448) Advanced BLs to create inventory lines
[#4450](#4450) Tablet optimized inventory-counting-window
[#4482](#4482) Support Doctype Text templates also on purchase order
[#4498](#4498) Make fields in explicit user filter mandatory or optional
[#4501](#4501) LogicExpressionEvaluator: improve error message in case something went wrong
[#4517](#4517) Extend Sales Order REST API to support price and support all product values
[#1878](metasfresh/metasfresh-webui-frontend-legacy#1878) Forgot password feature
[#4483](#4483) Payment allocation form does not show invoices
[#4499](#4499) Cannot create letter
[#4504](#4504) Mandatory logic broken for C_FlatrateTerm.C_Currency_ID
[#4506](#4506) Compensation Group's subtotals gets broken after setting/changing the flatrate conditions
[#4509](#4509) NPE in Compensation Groups creation
[#4514](#4514) Include sales orders REST API to metasfresh-dist/serverRoot
[#1188](metasfresh/metasfresh-webui-frontend-legacy#1188) Home and End button move caret in text fields
[#1463](metasfresh/metasfresh-webui-frontend-legacy#1463) Unable to execute any quick actions in Firefox
[#1578](metasfresh/metasfresh-webui-frontend-legacy#1578) Applied filter params sometimes not displayed in filter
[#1589](metasfresh/metasfresh-webui-frontend-legacy#1589) included tab: when refreshing via websocket event the sort/order is not preserved
[#1707](metasfresh/metasfresh-webui-frontend-legacy#1707) Red line is missing when a document was not saved
[#1872](metasfresh/metasfresh-webui-frontend-legacy#1872) [alt]+u not working as before
[#1923](metasfresh/metasfresh-webui-frontend-legacy#1923) Sequence of Dropdowns in combined Business Partner Lookups not working
[#1927](metasfresh/metasfresh-webui-frontend-legacy#1927) No additional filter parameter from a dropdown selectable when filter has a default value set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants